Skip to content

feat(ios): add token activity calendars for 2.0 - #123

Merged
o1xhack merged 11 commits into
mobile-devfrom
feature/ios-2-token-activity
Sep 11, 2026
Merged

o1xhack merged 11 commits into
mobile-devfrom
feature/ios-2-token-activity

Conversation

@o1xhack

@o1xhack o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Changes

Adds iOS 2.0 Token Activity calendars below provider subscription utilization and a combined token total card above Daily Spend that opens the per-provider activity detail. Calendars show up to 365 days, support horizontal scrolling and date selection, and distinguish unavailable token counts from confirmed zero. Codex Service Mix now lives in Codex Usage details.

Preserves token availability through local ledger storage and aggregation, runs history preparation in the background, and includes four-language UI and release notes. All iOS targets are 2.0.0 (200). No Mac payload or CloudKit schema change is needed.

Validation

  • 744 tests across 49 suites passed, including frozen 1.24 local database migration and multi-device aggregation fixtures.
  • Two focused simulator UI tests passed, including Cost summary-to-detail navigation; additional dark/large-text provider check passed.
  • Portable lint and localization audit passed; focused new iOS files passed lint. Four existing CostLedgerService structural lint findings remain unchanged.
  • Signed Release archive succeeded; app and extensions verified as 2.0.0 (200), with CloudKit Production entitlements.
  • Research/053-ios-2-token-activity records evidence and all 16 compatibility combinations as substituted verification, not physical-device passes.

Final full regression: 744 unit tests and two UI flows passed, including catch-up publication refresh, end-to-end two-Mac counter saturation, confirmed-zero histories with the ledger disabled, and the exact 365-day calendar boundary.

Remaining validation boundaries

The reported real-account cost decrease from roughly $10,000 to $8,808.47 has not been reconciled across the user's two Macs and iPhone; this PR does not claim to fix that discrepancy. Historical coverage remains bounded by available synced data, up to 365 days. TestFlight upload follows the current-head review gate; no App Store submission is included.

Review policy correction

Removes a stale fork-owned requirement to use Claude/Opus specifically for release review, as explicitly requested by the user. Retains the complete current-head Codex review, thread-resolution, and CI gates.

@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T22:13:45.086183Z b8c0c0e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@o1xhack
o1xhack marked this pull request as draft September 11, 2026 21:07
@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49a8d23c01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CodexBarMobile/CodexBarMobile/Views/TokenActivityView.swift
@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 503b2241ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@o1xhack
o1xhack marked this pull request as ready for review September 11, 2026 21:38

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac2219360c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CodexBarMobile/CodexBarMobile/ContentView.swift
@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc55292133

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CodexBarMobile/CodexBarMobile/Views/TokenActivityView.swift Outdated
Comment thread CodexBarMobile/CodexBarMobile/Storage/CostHistoryWorker.swift
@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b52c45398

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CodexBarMobile/CodexBarMobile/Views/TokenActivityView.swift Outdated
Comment thread CodexBarMobile/CodexBarMobile/Views/TokenActivityView.swift Outdated
@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Codex review architecture audit
Head: 3b52c45
Repeated finding pattern: Edge semantics were implemented in individual UI locations rather than carried consistently from source publications, calendar mapping and aggregate knownness through every display path.
Root design/requirements problem: The original heatmap added ad-hoc refresh strings and numeric reductions around an existing ledger. That duplicated the domain rules for producer-calendar boundaries, missing versus zero data, lower-bound totals, and safe aggregation. Tests initially emphasized individual reducers and presentation, leaving cross-layer combinations uncovered.
Revised approach: Centralize producer/reader calendar refresh identity in TokenActivity and make all aggregate displays consume one typed total carrying optional value and lower-bound status. Preserve the existing actor loader and shared series for Cost summary/detail. Test unchanged publications across a producer midnight, complete zero, absent data, partial known contributions and saturated sums; retain end-to-end multi-Mac ledger and full iOS/UI gates. Only request the next review after these changes and tests pass.

@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: b8c0c0e5e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Current-head CR complete:

  • Head: b8c0c0e
  • Codex clean conclusion received; Scripts/check_pr_review_gate.sh 123 passes (6 rounds, 0 unresolved threads, required architecture audit recognized).
  • PR Fast Checks: SUCCESS; merge state CLEAN.
  • Latest full regression: 744 unit tests / 49 suites and 2 UI flows passed (/tmp/cbm-2-semantics-tests.log).
  • Signed archive: /tmp/CodexBarMobile-2.0.0-200-b8c0c0e5e.xcarchive; archive succeeded and codesign --verify --deep --strict passed.
  • Cost summary/detail navigation and four-language release notes are included. Claude-specific review requirement was removed at the user's direction.
  • Not merged or uploaded yet. TestFlight upload is authorized; merge remains pending explicit authorization under the user's original no-merge restriction. Real-account historical dollar reconciliation remains an explicitly unverified boundary.

@o1xhack
o1xhack merged commit f9a5754 into mobile-dev Sep 11, 2026
1 check passed
@o1xhack

o1xhack commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

PR #123 merged as f9a5754; Final CI 34657352376 succeeded. iOS 2.0.0 (200) uploaded successfully from the tree-identical reviewed archive.

ASC build 4e53fcca-dd57-45ee-b360-04a692c8f52a is VALID / IN_BETA_TESTING and appears in the Internal group's builds. All four beta note locales match local release notes exactly. Apple CDN icon visually verified from altool iconAssetToken. No external Beta Review, App Review or live release was submitted.

The requested independent TestFlight workflow and release evidence are in PR #124; that documentation PR does not block this completed beta upload. Real-device historical cost reconciliation remains unverified as previously documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant