Skip to content

fix(sync): close post-merge release blockers - #71

Merged
o1xhack merged 23 commits into
mobile-devfrom
review/pr69-fleet-snapshot-deletion
Aug 8, 2026
Merged

o1xhack merged 23 commits into
mobile-devfrom
review/pr69-fleet-snapshot-deletion

Conversation

@o1xhack

@o1xhack o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • reconcile Mac fleet AccountSnapshot records and delete stale records owned by the current Mac
  • keep foreign-device snapshots intact and clear local caches only after confirmed deletion
  • use POSIX rename for atomic cost-cache replacement so Linux warm scans do not lose codex-v11.json
  • regenerate the parser hash and record the post-merge review evidence

Verification

  • swift test --no-parallel: 8342 tests / 812 suites passed after the fleet-sync fix
  • focused CloudSyncSettingsTests and CostUsageCacheTests: 36 tests passed on final sources
  • bash Scripts/lint.sh lint: passed, 0 violations
  • PR 69 Final CI reproduced the cache failure on both Linux x64 and arm64; this PR carries the deterministic fix

Closes the post-merge P1 review thread from PR #69.

@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e3784078c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review\n\nRe-review latest commit 9f47a65 after resolving the authoritative snapshot deletion and pending-delete cancellation findings.

@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit a27afd5 after the disabled-provider stale-memory self-review fix.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a27afd56b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/UsageStore+WidgetSnapshot.swift Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 1242123 after the durable last-token-account removal fix.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1242123a27

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 2a20e30 after scoping durable snapshot tombstones to removed account records and preserving same-provider fallback snapshots.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a20e30ec1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 456c43d after adding throttled-queue reconciliation and conservative legacy ownership backfill.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 456c43db74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit e0d5219 after removing display-label ownership inference and invalidating stale provider authority after queued account deletion.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0d5219f50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit abe3017 after binding snapshot data and deletion authority to per-provider config revisions and reading enabled/account state at consumption time.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: abe301756b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 81adc9a after provider-sliced pending reconciliation, pre-push revision validation, and tombstone-aware authority downgrade.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81adc9a59f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/UsageStore+WidgetSnapshot.swift Outdated
Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit c5afcf3. Please re-review the complete PR diff, with special attention to provider-scoped snapshot authority and same-revision partial publication reconciliation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5afcf3728

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/UsageStore+WidgetSnapshot.swift Outdated
Comment thread Sources/CodexBar/UsageStore+WidgetSnapshot.swift Outdated
Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit a948cb99ee3bdc8351c8a5ad20b16cf0595fbb66. Please review this exact SHA, focusing on external/remote account-removal reconciliation, config revision ordering, startup repair safety, and regressions.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a948cb99ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift
Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit a98cac24fed42c9756a814ddb205d2465e2ccafb. Please review this exact SHA and full PR diff, focusing on destructive startup authority, provider-scoped snapshot deletion, and local-vs-external revision ordering.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a98cac24fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 57351687a637321da697bdbb5a33187a899ff17a. Please review this exact SHA and complete diff, focusing on stale-but-valid startup config authority, cancellation persistence across disabled/re-enabled sync, and external/local ordering.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57351687a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexBar/Sync/CloudSyncEngine.swift
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit c2622aafd94befc689b607980d49097f29543511 only. Please inspect the full PR diff for blocking correctness, data-loss, sync-compatibility, versioning, and release issues. Report only findings introduced or still present at this exact SHA.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: c2622aafd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 71772e15e644d9fe2b5003c15c188fdc05f3fa73 only. Please inspect the full PR diff and the Linux descriptor-reuse test correction for blocking correctness, data-loss, sync-compatibility, versioning, release, and test-validity issues. Report only findings introduced or still present at this exact SHA.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 71772e15e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 50277b4d926d2bed9eeea871c149aa3c15d37d65 only. Please inspect the full PR diff and the Swift test-discovery retry hardening for blocking correctness, data-loss, sync-compatibility, versioning, release, CI-integrity, and test-validity issues. Report only findings introduced or still present at this exact SHA.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50277b4d92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Scripts/ci_swift_test_by_suite.py Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 29f2da8fb60eca59308c452774dac1c7f9470bf0 only. Please inspect the full PR diff and especially the two-of-three Swift test-discovery completeness quorum for blocking correctness, data-loss, sync-compatibility, versioning, release, CI-integrity, and test-validity issues. Report only findings introduced or still present at this exact SHA.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29f2da8fb6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Scripts/ci_swift_test_by_suite.py Outdated
Comment thread CodexBarMobile/Research/045-v047-upstream-sync/03-testing.md Outdated
@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit a17ed979f88e91303ea09809a4727f7bd75700e5 only. Please inspect the full PR diff, the fixed four-attempt strict discovery consistency gate, and current-SHA release test evidence for blocking correctness, data-loss, sync-compatibility, versioning, release, CI-integrity, documentation accuracy, and test-validity issues. Report only findings introduced or still present at this exact SHA.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: a17ed979f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@o1xhack

o1xhack commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review latest commit 638c01cf3b92d080dee2b96a131b459fe8fa14de only. This is a docs-only evidence closeout after code SHA a17ed97 passed exact-SHA review and Final CI run 31239327715. Please inspect the full PR diff and final Research evidence for any remaining blocking correctness, sync-compatibility, versioning, release, CI-integrity, or documentation-accuracy issues. Report only findings introduced or still present at this exact SHA.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 638c01cf3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@o1xhack
o1xhack merged commit 98f5e55 into mobile-dev Aug 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant