Skip to content

Conversation

@Warchamp7
Copy link
Member

Description

Updates the local file scheme handler to use a custom protocol rather than http and skips any file path that contains an IP address.

Motivation and Context

Security improvements to local file handling.

How Has This Been Tested?

I have mirrored these changes to an in-tree build of OBS. I have not tested building the submodule itself.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested a review from PatTheMav January 21, 2026 19:29
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits.

@Warchamp7 Warchamp7 force-pushed the browser-scheme-changes branch from b663192 to b156dc0 Compare January 21, 2026 19:33
@Warchamp7 Warchamp7 force-pushed the browser-scheme-changes branch from b156dc0 to 81ab2de Compare January 21, 2026 22:17
@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Jan 22, 2026
@Warchamp7 Warchamp7 force-pushed the browser-scheme-changes branch from 81ab2de to 69732d2 Compare January 22, 2026 18:56
@Warchamp7 Warchamp7 force-pushed the browser-scheme-changes branch from 69732d2 to 4ac792a Compare January 22, 2026 21:33
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to think this looks good now, but I don't have time to check this functionally again tonight, can give a final approval tomorrow.

@RytoEX RytoEX requested review from PatTheMav and RytoEX January 23, 2026 18:05
@RytoEX RytoEX merged commit 8a45650 into obsproject:master Jan 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue

Projects

Status: Ready For Merge

Development

Successfully merging this pull request may close these issues.

3 participants