-
Notifications
You must be signed in to change notification settings - Fork 246
Update local file scheme handler #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RytoEX
requested changes
Jan 21, 2026
Member
RytoEX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits.
b663192 to
b156dc0
Compare
PatTheMav
reviewed
Jan 21, 2026
b156dc0 to
81ab2de
Compare
PatTheMav
reviewed
Jan 22, 2026
81ab2de to
69732d2
Compare
PatTheMav
reviewed
Jan 22, 2026
69732d2 to
4ac792a
Compare
PatTheMav
reviewed
Jan 22, 2026
Member
PatTheMav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to think this looks good now, but I don't have time to check this functionally again tonight, can give a final approval tomorrow.
RytoEX
approved these changes
Jan 23, 2026
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the local file scheme handler to use a custom protocol rather than http and skips any file path that contains an IP address.
Motivation and Context
Security improvements to local file handling.
How Has This Been Tested?
I have mirrored these changes to an in-tree build of OBS. I have not tested building the submodule itself.
Types of changes
Checklist: