Skip to content

Stop network panel height loops from forcing Wi-Fi reconnects (#11099) - #12185

Open
thescurry wants to merge 1 commit into
omacom:quattrofrom
thescurry:cursor/network-panel-binding-loop-6c82
Open

thescurry wants to merge 1 commit into
omacom:quattrofrom
thescurry:cursor/network-panel-binding-loop-6c82

Conversation

@thescurry

Copy link
Copy Markdown

Summary

Fixes #11099

height: visible ? implicitHeight : 0 on Wi-Fi list header/status Text caused QML binding loops. Scan churn thrashed layout; a stale click/band pin then called connection-activate (~15s full reauth).

  • Drop those height binds (Column already skips invisible children)
  • Skip list replace when projected rows unchanged
  • Refuse connect/band/disconnect/forget while panel closed or layout settling
  • Refuse connect when already connected; disable row MouseAreas when closed
  • Short note in docs/omarchy-shell.md

Test plan

  • bash test/shell.d/network-test.sh + network-layout-test.sh
  • Open network panel, let Wi-Fi list refresh; no Binding loop spam; no surprise reconnect

Code QA Pass @ f0899c8. Fork review: thescurry#4

Text/header height binds were looping on list rebuilds; the layout
thrash could activate a connection. Collapse with visible only, and
refuse activate while closed, settling, or already connected.

Co-authored-by: Steve Curry <thescurry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network panel QML binding loop forces a full wifi reconnect, causing ~15s outages

2 participants