Conversation
Runtime state writes under a plugin dir (data.json, caches, binaries) were triggering full bar teardowns via the recursive inotify watch. Allowlist manifest/QML/JS paths so helper churn cannot storm-reload the shell. Fixes omacom#12158
|
The new filter also suppresses whole-plugin directory moves. I checked Could directory create/move/delete events remain eligible for rescanning while runtime-file writes stay filtered? A regression test that moves a populated plugin directory into the watched tree would cover this without needing a running desktop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest.json/*.manifest.json/*.qml/*.jsso runtime state writes (e.g.data.json, caches, binaries) no longer tear down the whole bar.inotifywait --includeand inlocalPluginIdForPathas defense in depth.Fixes #12158
This is intentionally an allowlist rather than extending the denylist approach in related PRs like #12020 / #10705 — those still fire on arbitrary files such as
data.json.Test plan
bash test/shell.d/plugin-registry-contract-test.shinotifywait --include '(manifest\.json$|\.manifest\.json$|\.(qml|js)$)'—data.jsonsuppressed;.qml/manifest.json/.jsstill fireLocal plugin changed, reloading.qml/manifest.jsonand confirm hot-reload still works