fix(image_mcp.py): use consistant argument (#929)#968
Open
MaoSong2022 wants to merge 1 commit intoopen-compass:mainfrom
Open
fix(image_mcp.py): use consistant argument (#929)#968MaoSong2022 wants to merge 1 commit intoopen-compass:mainfrom
MaoSong2022 wants to merge 1 commit intoopen-compass:mainfrom
Conversation
Member
|
Hi, @MaoSong2022 , It looks like every other dataset do not set the arg names explicitly, so I don't think the modification is necessary. |
Collaborator
Author
|
the change is to keep the arguments consistent with
the question is should we use consistent arguments when inheriting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix argument error in MMMU_Pro benchmark, close #929