Skip to content

feat: assert no error event during ready -> stale -> ready #387

Closed

Description

@toddbaert

Context

Part of open-feature/flagd#2027.

The ready -> stale -> ready scenario in gherkin/events.feature registers an error event handler but never asserts it stays silent. So a spurious PROVIDER_ERROR during a short (< grace period) disconnect goes uncaught. flagd#2027 changes the default retryBackoffMaxMs/retryGracePeriod to 5s/10s so a normal reconnect resolves inside the grace window (STALE -> READY, no ERROR); this scenario should assert exactly that.

Scenario change needed

  • In the ready -> stale -> ready scenario, add a step asserting the error event handler did not fire:
    And the error event handler should not have been executed

Notes

  • This introduces a new gherkin step; provider step definitions must implement the negative assertion when they bump to a testbed release containing this change.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions