achievements: add certifications to achievements (fixes #8657) - #10046
Open
RyanS4 wants to merge 1 commit into
Open
achievements: add certifications to achievements (fixes #8657)#10046RyanS4 wants to merge 1 commit into
RyanS4 wants to merge 1 commit into
Conversation
Similar to achievements, users can now provide a summary of their certifications and maintain a manual list of certifications. - Updated UsersAchievementsUpdateComponent with new form controls and dialogs - Updated UsersAchievementsComponent to display manual certifications - Renamed existing auto-earned certifications to 'earnedCertifications' to avoid conflict - Updated PDF generation to include manual certifications and summary - Fixed manual certification list items to correctly show links by making them identical to achievement list items - Updated UsersAchievementsService to include new fields in empty-check logic - Added i18n tags for new labels and headers Co-authored-by: RyanS4 <179627679+RyanS4@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR extends the user Achievements feature to support a certifications summary and a manually maintained certifications list (in addition to existing auto-earned certifications), and ensures these certifications appear in both the profile view and PDF export.
Changes:
- Adds new form controls and dialogs to create/edit a “Summary of Certifications” plus a manual certifications list.
- Renames auto-earned certifications display state to
earnedCertificationsand updates the profile view/PDF export to render manual + earned certifications. - Updates “empty achievements” detection to account for the new certifications fields and to be null-safe for list fields.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/users/users-achievements/users-achievements.service.ts | Extends isEmpty() logic to include certifications fields and handle missing arrays safely. |
| src/app/users/users-achievements/users-achievements.component.ts | Renames auto-earned certs state and includes manual certifications + summary in PDF generation. |
| src/app/users/users-achievements/users-achievements.component.html | Adds UI sections for manual certifications and renames the earned certifications section. |
| src/app/users/users-achievements/users-achievements-update.component.ts | Adds reactive form controls and dialog plumbing for certifications summary + manual certifications list. |
| src/app/users/users-achievements/users-achievements-update.component.html | Adds new “Summary of Certifications” field and a step-list UI for manual certifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <h3 i18n>My Certifications</h3> | ||
| <td-markdown [content]="achievements.certificationsHeader"></td-markdown> | ||
| <mat-list> | ||
| @for (certification of achievements.certifications; track certification; let i = $index) { |
| } | ||
| } | ||
| </span> | ||
| <span class="achievement-date">{{certification.date | date: medium}}</span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8657
Similar to achievements, users can now provide a summary of their certifications and maintain a manual list of certifications.