fix: this change introduces strict versioning for docs#58
Merged
Conversation
This change adds strict versioning for docs from the markdown gen. This means that the markdown generator will properly support specific versions and will need to be extended explicitly if we have a version change This introduction allows us to be more intentional about what tool supports what version
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 83.64% 83.64%
=======================================
Files 3 3
Lines 1137 1137
=======================================
Hits 951 951
Misses 186 186
🚀 New features to boost your workflow:
|
shanejonas
reviewed
Feb 27, 2026
|
|
||
| }; | ||
|
|
||
| export type OpenrpcDocument = V1_3.OpenrpcDocument | V1_4.OpenrpcDocument; |
Member
There was a problem hiding this comment.
do we need all this if we have spec types?
Member
Author
There was a problem hiding this comment.
yeah all consumers have to opt into joint types , perhaps in the future we publish an omni type , not sure if that will be always useful is the only concern there. Maybe as we expand we can work that out
shanejonas
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds strict versioning for docs from the markdown gen. This means that the markdown generator will properly support specific versions and will need to be extended explicitly if we have a version change
This introduction allows us to be more intentional about what tool supports what version