Closed
Conversation
This patch adds a new configuration for jsoncpp_test in the BUILD.bazel file.
Pull Request Test Coverage Report for Build 13823356124Details
💛 - Coveralls |
bcsgh
reviewed
Mar 17, 2025
| "include/json/writer.h", | ||
| ], | ||
| copts = [ | ||
| "-DJSON_USE_EXCEPTION=0", |
Contributor
There was a problem hiding this comment.
Removing this could be a breaking change for some users. I think a better way to do this would be: #1600
| textual_hdrs = ["src/lib_json/json_valueiterator.inl"], | ||
| ) | ||
|
|
||
| cc_binary( |
Contributor
There was a problem hiding this comment.
Both of these should likely be testonly=True and should probably also be in BUILD.bazel files in their respective directories.
| deps = [":jsoncpp"], | ||
| ) | ||
|
|
||
| cc_binary( |
Contributor
There was a problem hiding this comment.
I think this could just be made to be a cc_test rule. ...
And I got a little carried away check if that was true: #1601
(That said, I'm not 100% happy with how that came out if you want to take a run at making it cleaner.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a new configuration for jsoncpp_test in the BUILD.bazel file.