Collect async exemplars when exemplar filter is always_on#8363
Conversation
Allow asynchronous metric storage to use the configured exemplar filter so always_on can capture async exemplars, matching the clarified spec. Add coverage at both the storage and SDK integration levels. Refs open-telemetry#8355
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8363 +/- ##
=========================================
Coverage 90.87% 90.87%
+ Complexity 7989 7986 -3
=========================================
Files 898 898
Lines 24119 24111 -8
Branches 2412 2408 -4
=========================================
- Hits 21919 21912 -7
+ Misses 1456 1455 -1
Partials 744 744 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Thanks for picking this up. Just one comment, but looks pretty good on the whole
|
@jack-berg The requested async exemplar coverage has been added to all six instrument test classes with both |
| notCompatibleWithConfigurationCache( | ||
| "GraalVM native test agent options are not serializable for this task.", | ||
| ) | ||
| } |
There was a problem hiding this comment.
Please revert this. Are you having issues with graal tests and the configuration cache locally? I have in the past but thought they had been resolved. If they persist, let's cover in a separate PR. Thanks!
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Just some extra code for the configuration cache. But otherwise looks good. Thanks.
|
@jack-berg I'll revert the config-cache workaround so this PR stays focused on the exemplar change. If the Graal CI flake comes up again I'll address it separately. |
|
Thank you for your contribution @ADITYA-CODE-SOURCE! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
2 participants
Summary
Fixes #8355