fix(feature/loan): display Overpaid status for overpaid loan accounts

[Kartikey15dem]

Fixes - Jira-#MIFOSAC-637

Summary

Updated loan status handling to correctly display Overpaid for overpaid loan accounts in the Mobile App, aligning it with Web App behavior.

Issue

For overpaid loan accounts, the Web App correctly shows Overpaid, but the Mobile App was incorrectly displaying Loan Closed.

Behavior Changes

Before	After
overpaidBef.webm	overpaidAft.webm

Fix

Added explicit handling for status.overpaid == true to ensure the correct button text/status is shown.

Steps to Verify

1. Open the client loan list in the Web App → Account 000000016 shows Overpaid.
2. Open the same account in the Mobile App → Status now shows Overpaid.

Summary by CodeRabbit

• New Features
  • Displays an "Overpaid" status label in loan account summaries. A new public label "Overpaid" is used so accounts that have been overpaid are clearly indicated in the UI, including in status button/text where applicable.

[coderabbitai]

📝 Walkthrough

Walkthrough

Added a new public string resource feature_loan_overpaid with value "Overpaid" and updated LoanAccountSummaryScreen to return that string when a loan's status has overpaid == true.

Changes

Cohort / File(s)	Summary
Strings & UI feature/loan/src/commonMain/composeResources/values/strings.xml, feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountSummary/LoanAccountSummaryScreen.kt	Added feature_loan_overpaid = "Overpaid" to strings.xml. Imported the resource in LoanAccountSummaryScreen and added a branch in getButtonText to return feature_loan_overpaid when status.overpaid == true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• TheKalpeshPawar

Poem

🐰 I hopped through strings with glee today,
"Overpaid" now hums where balances lay,
A tiny tweak, a cheerful tune,
Buttons whisper bright as noon,
Carrots clapped—code leaps all the way! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(feature/loan): display Overpaid status for overpaid loan accounts' clearly and concisely summarizes the main change: adding display of 'Overpaid' status for overpaid loan accounts in the loan feature.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

• ✨ 136.113.208.247/32 (new)
• 34.170.211.100/32
• 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Updates loan status rendering in the Loan Account Summary so overpaid loan accounts display an Overpaid label (instead of being treated like closed), aligning Mobile App behavior with the Web App.

Changes:

• Add explicit status.overpaid == true handling in getButtonText(...).
• Add a new localized string resource for the overpaid label.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountSummary/LoanAccountSummaryScreen.kt	Adds an overpaid branch in button/status text selection for loan summary UI.
feature/loan/src/commonMain/composeResources/values/strings.xml	Introduces a new string resource used to render the overpaid label.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountSummary/LoanAccountSummaryScreen.kt (1)

698-718: ⚠️ Potential issue | 🟠 Major

Move overpaid check before closedObligationsMet to prevent masking.

The overpaid == true branch can be masked if a loan status has both closedObligationsMet == true and overpaid == true set simultaneously. The first branch would match and return "Make Repayment", preventing the "Loan Overpaid" text from ever displaying. Reorder the conditions to check overpaid before the closedObligationsMet check.

Suggested reorder

 `@Composable`
 fun getButtonText(status: LoanStatusEntity): String {
     return when {
+        status.overpaid == true -> {
+            stringResource(Res.string.feature_loan_overpaid)
+        }
         status.active == true || status.closedObligationsMet == true -> {
             stringResource(Res.string.feature_loan_make_Repayment)
         }
@@
-        status.overpaid == true -> {
-            stringResource(Res.string.feature_loan_overpaid)
-        }
-
         else -> {
             stringResource(Res.string.feature_loan_closed)
         }
     }
 }

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountSummary/LoanAccountSummaryScreen.kt (1)

698-720: ⚠️ Potential issue | 🟠 Major

Move overpaid check before closedObligationsMet to ensure correct status priority.

The overpaid condition (line 712) is evaluated after closedObligationsMet (line 700). Since these flags are independent at the API level and both can be true simultaneously (as shown by the direct 1-to-1 mapping in GetClientsClientIdAccountMapper), an overpaid loan with closedObligationsMet == true will match the first condition and return "Make Repayment" instead of "Overpaid", making the overpaid check unreachable.

Proposed fix

 fun getButtonText(status: LoanStatusEntity): String {
     return when {
+        status.overpaid == true -> {
+            stringResource(Res.string.feature_loan_overpaid)
+        }
+
         status.active == true || status.closedObligationsMet == true -> {
             stringResource(Res.string.feature_loan_make_Repayment)
         }

         status.pendingApproval == true -> {
             stringResource(Res.string.feature_loan_approve_loan)
         }

         status.waitingForDisbursal == true -> {
             stringResource(Res.string.feature_loan_disburse_loan)
         }

-        status.overpaid == true -> {
-            stringResource(Res.string.feature_loan_overpaid)
-        }
-
         else -> {
             stringResource(Res.string.feature_loan_closed)
         }
     }
 }

[gururani-abhishek]

Hi @Kartikey15dem, thanks for your PR.
Can you also add screenshots from the Web App which you've taken as reference, make sure you use the same accountNumber.
Also can you tell me what is the status of localised text in android-client App? Will your change support localised text?

edit : tagged the wrong person :p