Skip to content

Feat/reorganize toplevel navigation#911

Merged
scheidtdav merged 40 commits intodevfrom
feat/reorganize-toplevel-navigation
May 7, 2026
Merged

Feat/reorganize toplevel navigation#911
scheidtdav merged 40 commits intodevfrom
feat/reorganize-toplevel-navigation

Conversation

@jona159
Copy link
Copy Markdown
Contributor

@jona159 jona159 commented May 4, 2026

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

jona159 added 22 commits May 4, 2026 09:31
@jona159
feat: info menu
ee994a1
@jona159
feat: add topbar button variant for coherent styling
64aa69f
@jona159
feat: use osem logo with text for home button
b8e8768
@jona159
feat: info menu component with informational links
5f3b642
@jona159
feat: translations
80293a1
@jona159
feat: add method to get total count of measurements
bd076c7
@jona159
feat: download label
547d029
@jona159
feat: topbar component, show devices and measurement stats
2d5e4eb
@jona159
feat: format
0018345
@jona159
refactor: download component
bbd2552
@jona159
feat: adjust info component
6fa1d32
@jona159
feat: adjust menu component
c391a21
@jona159
feat: add settings component for header, minor things
3aaa261
@jona159
Merge branch 'dev' into feat/reorganize-toplevel-navigation
4b8d4af
@jona159
fix: after conflict
589665f
@jona159
fix: pass user from loader
db30406
@jona159
fix: rm unnecessary stuff
7ad4908
@jona159
feat: show logo and stats together
e165f30
@jona159
feat: add language dialog for the future
98d6fee
@jona159
feat: show current language on hover only
3f2063f
@jona159
fix: dont show settings menu for now
f58a169
@jona159
fix: rm translation
528a2b9
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.22% 1775 / 2564
🔵 Statements 67.52% 1844 / 2731
🔵 Functions 69.24% 367 / 530
🔵 Branches 56.26% 948 / 1685
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/db/models/measurement.server.ts 50% 31.81% 69.23% 49.23% 33-158, 183, 184, 193-197, 238-240, 244, 308
Generated in workflow #2516 for commit 6c151a3 by the Vitest Coverage Report Action

@jona159 jona159 mentioned this pull request May 4, 2026
Merged
9 tasks
scheidtdav
scheidtdav reviewed May 4, 2026
View reviewed changes
Comment thread app/components/header/home/index.tsx Outdated
@scheidtdav scheidtdav linked an issue May 4, 2026 that may be closed by this pull request
re-organize start page and top level navigation #906
Closed
@jona159 jona159 marked this pull request as ready for review May 5, 2026 08:35
scheidtdav
scheidtdav approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@scheidtdav scheidtdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely more clean approach!
Some visual feedback:

Image

The pill-shaped logo in the top left seems to have a drastically different border-radius compared to the search bar.
The background opacity is also different.

I think the search bar should get its width limitation back.

One inconsistency (I know I advocated for having no menu for the language toggle):
All controls on the map show a menu on click, except for the logo box and the language toggle. The shape suggests something else.
Suggestion: Make the language switch pill-shaped as well, indicating that pill-shaped items act on click, while round buttons show a menu on click.
The tooltip should say what the pill-shaped thing does.
Alternative would also be a language menu of course.

Sidenote: Since we are looking at a map, a globe symbol for the language might be confusing. What do you think, should we go for something like languages?

Comment thread app/components/landing/header/language-dialog.tsx Outdated
jona159 and others added 12 commits May 6, 2026 10:16
@jona159 @scheidtdav
feat: make map landing page, mv current to about (#907)
b8e51a4 
* feat: make map landing page, mv current to about

* fix: update copyright year

* feat: improve hosted text

* fix: copyright year, twitter icon

* fix: translations

* fix: openSenseLab logo

* fix: rm scroll snapping

* fix: translations

* feat: animate heading

* fix: rm features

* feat: show copyright year dynamically

---------

Co-authored-by: David Scheidt <scheidtdav@users.noreply.github.com>
@dependabot @jona159
build(deps): bump @directus/sdk from 21.2.2 to 21.3.0 (#924)
6f197b6 
Bumps [@directus/sdk](https://github.com/directus/directus/tree/HEAD/sdk) from 21.2.2 to 21.3.0.
- [Release notes](https://github.com/directus/directus/releases)
- [Commits](https://github.com/directus/directus/commits/HEAD/sdk)

---
updated-dependencies:
- dependency-name: "@directus/sdk"
  dependency-version: 21.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @scheidtdav @jona159
build(deps-dev): bump @react-router/dev from 7.14.2 to 7.15.0 (#925)
79aab27 
* build(deps-dev): bump @react-router/dev from 7.14.2 to 7.15.0

Bumps [@react-router/dev](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dev) from 7.14.2 to 7.15.0.
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dev/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/@react-router/dev@7.15.0/packages/react-router-dev)

---
updated-dependencies:
- dependency-name: "@react-router/dev"
  dependency-version: 7.15.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* use new stable syntax

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Scheidt <david.scheidt@opensenselab.org>
@jona159
feat: differentiate pill shape buttons in topbar
4900140
@jona159
feat: shared style for topbar elements
f9eb00d
@jona159
feat: button sizes
fb4fe72
@jona159
feat: wrap in tooltip provider
fa2dc87
@jona159
feat: visually align topbar elements
248be2b
@jona159
feat: translations
4ab3716
@jona159
fix: rm unused
2324026
@jona159
Merge branch 'dev' into feat/reorganize-toplevel-navigation
1dc4abd
@scheidtdav
Merge branch 'dev' into feat/reorganize-toplevel-navigation
6c151a3
@zven
Copy link
Copy Markdown
Member

zven commented May 7, 2026

Definitely more clean approach! Some visual feedback:
Image

The pill-shaped logo in the top left seems to have a drastically different border-radius compared to the search bar. The background opacity is also different.

I think the search bar should get its width limitation back.

One inconsistency (I know I advocated for having no menu for the language toggle): All controls on the map show a menu on click, except for the logo box and the language toggle. The shape suggests something else. Suggestion: Make the language switch pill-shaped as well, indicating that pill-shaped items act on click, while round buttons show a menu on click. The tooltip should say what the pill-shaped thing does. Alternative would also be a language menu of course.

Sidenote: Since we are looking at a map, a globe symbol for the language might be confusing. What do you think, should we go for something like languages?

Good points! I like the idea with the alternative langauge symbol. 👍 I'm for styling UI elements that do similar things in a similar fashion.

@scheidtdav scheidtdav merged commit def4838 into dev May 7, 2026
6 checks passed
@scheidtdav scheidtdav deleted the feat/reorganize-toplevel-navigation branch May 7, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scheidtdav scheidtdav scheidtdav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

re-organize start page and top level navigation

3 participants

@jona159 @zven @scheidtdav