Repository navigation
Drop out-of-range coordinates and oversized polygons without dropping large real parcels - #720
Merged
Merged
Conversation
…ead of a 5 degree feature extent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #719. The Parcels run on 2026-10-26 finished in about 13 hours (job 83c36518: 3.9 hours of overview, 4.3 hours of detail with the slowest shard 4.3 hours and every shard under 2.7GB, then the join and upload), so the world-sized polygons were the cause of the 57 hour shard. Its logs also showed what the 5 degree feature extent rule from #719 dropped:
So the rule worked for Washington, caught Howard for the wrong reason, and wrongly dropped about 10 legitimate large polygons, because a degree of longitude is short at high latitude. The published parcels tileset from that run is missing them until the next run; the 3.3M-feature Washington file's real largest polygon is only about 1.1 degrees, but these others are much larger.
This replaces the feature-wide 5 degree extent rule with two separate checks in
badGeometry:Points and lines are only checked for range.
Run over the real sources with the new function:
The log now has a separate line for each kind, naming the job and source.
The Howard County source is still broken upstream and will never produce parcels until its coordinates are fixed; that is a source configuration problem, not something fabric can repair, and it is not new (those features can never be tiled).