Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/autocomplete/autocomplete.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ func getAllPossibleCompletions(completionStyle CompletionStyle, root *cli.Comman
// Completing a flag name
if isFlag(current) {
for _, flag := range cmd.Flags {
if vf, ok := flag.(cli.VisibleFlag); ok && !vf.IsVisible() {
continue
}
completions = builder.createFromFlag(current, &flag, completions)
}
}
Expand Down
38 changes: 38 additions & 0 deletions internal/autocomplete/hidden_flags_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package autocomplete

import (
"testing"

"github.com/stretchr/testify/require"
"github.com/urfave/cli/v3"
)

func TestFlagCompletionOmitsHiddenFlags(t *testing.T) {
t.Parallel()

root := &cli.Command{
Name: "openai",
Flags: []cli.Flag{
&cli.StringFlag{Name: "visible", Aliases: []string{"v"}},
&cli.StringFlag{Name: "hidden", Aliases: []string{"h"}, Hidden: true},
},
}

longResult := GetCompletions(CompletionStyleZsh, root, []string{"--"})
longNames := completionNames(longResult.Completions)
require.Contains(t, longNames, "--visible")
require.NotContains(t, longNames, "--hidden")

shortResult := GetCompletions(CompletionStyleZsh, root, []string{"-"})
shortNames := completionNames(shortResult.Completions)
require.Contains(t, shortNames, "-v")
require.NotContains(t, shortNames, "-h")
}

func completionNames(completions []ShellCompletion) []string {
names := make([]string, 0, len(completions))
for _, completion := range completions {
names = append(names, completion.Name)
}
return names
}