Conversation
Castiron custom code✅ No new custom-code files detected. 5 mixed files remain; 0 existing customizations changed. Compared 5 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 34988849345 --repo openai/openai-cli \
--name castiron-custom-code-34988849345-1 --dir /tmp/castiron-custom-code-34988849345-1
git apply --stat /tmp/castiron-custom-code-34988849345-1/custom-code.patch
cat /tmp/castiron-custom-code-34988849345-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9d146cd3dfd56fec12156b8621ebe581bd4bbe62 4443e9eee9082e028e7dbc116b893009a07a99fa
python3 scripts/castiron/custom_code_report.py report \
--base 9d146cd3dfd56fec12156b8621ebe581bd4bbe62 \
--head 4443e9eee9082e028e7dbc116b893009a07a99fa --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-4443e9eee908
cat /tmp/castiron-custom-code-4443e9eee908/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The
float32formatter from #78 merged through #119, but the direct[]float32{0.1, 1.5}regression from #78 was left behind. Add the scalar control and comma-array case contributed by @sylvesterkaczmarek so the original behavior in #77 is covered.Before #119, the array case failed with
0.10000000149011612,1.5. On currentmain, it passes with0.1,1.5. Ten race-enabledTestEncoderuns, theapiformpackage tests, andgit diff --checkpassed.Fixes #77.