Skip to content

test(apiform): cover comma-form float32 regression - #191

Closed
saioai wants to merge 1 commit into
mainfrom
codex/float32-comma-regression-77
Closed

saioai wants to merge 1 commit into
mainfrom
codex/float32-comma-regression-77

Conversation

@saioai

@saioai saioai commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

The float32 formatter from #78 merged through #119, but the direct []float32{0.1, 1.5} regression from #78 was left behind. Add the scalar control and comma-array case contributed by @sylvesterkaczmarek so the original behavior in #77 is covered.

Before #119, the array case failed with 0.10000000149011612,1.5. On current main, it passes with 0.1,1.5. Ten race-enabled TestEncode runs, the apiform package tests, and git diff --check passed.

Fixes #77.

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

Castiron custom code

✅ No new custom-code files detected.

5 mixed files remain; 0 existing customizations changed.

Compared 9d146cd3dfd54443e9eee908. Generated baselines verified.

5 existing customizations unchanged
  • pkg/cmd/adminorganizationcertificate.go
  • pkg/cmd/cmd.go
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 34988849345 --repo openai/openai-cli \
  --name castiron-custom-code-34988849345-1 --dir /tmp/castiron-custom-code-34988849345-1
git apply --stat /tmp/castiron-custom-code-34988849345-1/custom-code.patch
cat /tmp/castiron-custom-code-34988849345-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 9d146cd3dfd56fec12156b8621ebe581bd4bbe62 4443e9eee9082e028e7dbc116b893009a07a99fa
python3 scripts/castiron/custom_code_report.py report \
  --base 9d146cd3dfd56fec12156b8621ebe581bd4bbe62 \
  --head 4443e9eee9082e028e7dbc116b893009a07a99fa --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-4443e9eee908
cat /tmp/castiron-custom-code-4443e9eee908/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@saioai
saioai marked this pull request as ready for review September 15, 2026 15:29
@saioai
saioai requested a review from a team as a code owner September 15, 2026 15:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T15:31:16.211778Z 4443e9e Draft marked ready
🔒 Security Review Completed 2026-09-15T15:33:35.550261Z 4443e9e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@saioai saioai closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comma-form float32 arrays are serialized with widened precision

1 participant