Restore Model in ResponsesClient
#870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nseOutputTokenUsageDetails in protocol models
joseharriaga
requested review from
ShivangiReja and
trrwilson
as code owners
christothes
reviewed
Dec 11, 2025
| public virtual RealtimeClient GetRealtimeClient(); | ||
| [Experimental("OPENAI001")] | ||
| public virtual ResponsesClient GetResponsesClient(); | ||
| public virtual ResponsesClient GetResponsesClient(string model); |
Collaborator
There was a problem hiding this comment.
Did we decide not to go with defaultModel?
Collaborator
Author
There was a problem hiding this comment.
It sounds like we will want to move this property into ResponsesClientOptions, which doesn't exist yet because we're waiting on the Config feature from System.ClientModel that Michael is working on. With the intention to minimize churn for users, I'm simply reverting the Model property to what we had before for now, and we can perform the change as a whole in the future.
christothes
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelinResponseClientResponseTokenUsage,ResponseInputTokenUsageDetails, andResponseOutputTokenUsageDetailsinto protocol models