fix: patch upload.php and media_model.php for k6 load testing#209
Open
sreeshanth-soma wants to merge 2 commits intoopenbroadcaster:5.5-developfrom
Open
fix: patch upload.php and media_model.php for k6 load testing#209sreeshanth-soma wants to merge 2 commits intoopenbroadcaster:5.5-developfrom
sreeshanth-soma wants to merge 2 commits intoopenbroadcaster:5.5-developfrom
Conversation
Temporary fixes to make the upload/media save pipeline work while the 5.5 refactor is in progress: - upload.php: OBFController → OpenBroadcaster\Base\Controller - upload.php: OB_UPLOADS → OB_MEDIA_UPLOADS (5 occurrences) - media_model.php: OB_UPLOADS → OB_MEDIA_UPLOADS (lines 1935, 2178) - media_model.php: add recursive flag to mkdir() (line 2806)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found these while building the k6 load testing tool, the upload/media save pipeline has a few references that haven't been updated yet in the 5.5 refactor:
public/upload.php:
OBFController→OpenBroadcaster\Base\Controller(class was renamed)OB_UPLOADS→OB_MEDIA_UPLOADS(constant renamed, 5 occurrences)core/models/media_model.php:
OB_UPLOADS→OB_MEDIA_UPLOADS(lines 1935, 2178)mkdir($checkDir)→mkdir($checkDir, 0755, true)(line 2806 — the other 3 mkdir calls in the same file already use recursive, this one was missed)These are needed for the k6 load testing tool to exercise the upload/media save pipeline.