This repository was archived by the owner on Nov 26, 2025. It is now read-only.
feat: add helm template validation for office suite exclusivity#124
Open
michaelstingl wants to merge 1 commit intomainfrom
Open
feat: add helm template validation for office suite exclusivity#124michaelstingl wants to merge 1 commit intomainfrom
michaelstingl wants to merge 1 commit intomainfrom
Conversation
- Add validateOfficeSuite helper function - Fail fast during helm template/install with clear error message - Prevents deployment of both Collabora and OnlyOffice simultaneously - Better user experience than runtime errors The validation explains that both services use the same WOPI endpoints and cannot coexist. Fixes #108
Contributor
Author
|
@mcfly-0908 @Tim-herbie - Since you both have experience with OnlyOffice in this chart, I'd appreciate your feedback on this validation improvement. This PR prevents the confusing runtime error when both office suites are enabled by failing fast during @Tim-herbie - As a reviewer with Triage permissions, your review and approval would be especially valuable! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Helm template validation to ensure only one office suite (Collabora or OnlyOffice) can be enabled at the same time.
Problem
Currently, the validation happens at runtime inside the OpenCloud application, leading to:
Solution
Added a validation helper that fails fast during
helm templateorhelm installwith a clear error message.Implementation
opencloud.validateOfficeSuitehelper in_helpers/tpl.yamlTesting
Benefits
Fixes #108