adr: Document OIDC client parameter discovery #2253
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically documents what as discussed in #2072 and https://github.com/opencloud-eu/internal/issues/172
I am mainly adding to this to keep a record of why we're doing it and how.
@kulmann To make all clients use the same mechanism for discovering the oidc parameter it would IMO be good if web could switch to as well. However, looking at the other OIDC related parameters that can be configured in web. I have some questions.
WEB_OIDC_METADATA_URL: This allows to set the URL for the.well-known/openid-configurationendpoint. Do we really need that? This should always be the issuer-url as returned in thehttp://openid.net/specs/connect/1.0/issuerrelation +.well-known/openid-configuration. The OIDC spec even define is as aMUST(https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderConfig).ResponseType: We default tocodehere, have we ever encountered the need to set something else? To we need to have this configurable?PostLogoutRedirectURI: I guess this is really specifc to web? So we should probably keep it in the config.json