fix(checkpoint): workaround to avoid mutate cgroupv2 mount options#5318
fix(checkpoint): workaround to avoid mutate cgroupv2 mount options#5318xujihui1985 wants to merge 1 commit into
Conversation
add --manage-cgroups-mode ignore to avoid pollute cgroupv2 mount options during unittest and intergration test checkpoint-restore/criu#3029 Signed-off-by: sean <xujihui1985@gmail.com>
|
@xujihui1985 an you explain what is the problem, show the output and all? It is not clear from the description |
See #5267. TL;DR: runc checkpoint/restore changes host cgroup2 mount options. |
Sorry for the confusion. This PR was split out from the original PR #5267 and provides a workaround for the problem described in this issue: checkpoint-restore/criu#3029 |
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks! Can we link the issue as a comment in the tests?
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
Sorry I didn't see this before, small simple fixes :)
| --manage-cgroups-mode=ignore \ | ||
| --work-path ./work-dir \ | ||
| --image-path ./image-dir \ | ||
| --manage-cgroups-mode ignore \ |
There was a problem hiding this comment.
This is wrong, it already has the option specified
| set_cgroups_path # Changes the path. | ||
| runc restore -d --manage-cgroups-mode ignore --pid-file pid \ | ||
| --work-path ./work-dir --console-socket "$CONSOLE_SOCKET" test_busybox | ||
| --work-path ./work-dir --console-socket "$CONSOLE_SOCKET" --manage-cgroups-mode ignore test_busybox |
3 participants
add --manage-cgroups-mode ignore to avoid pollute cgroupv2 mount options during unittest and intergration test
checkpoint-restore/criu#3029