Skip to content

[release-1.3] features: propagate version from the root urfave/cli command#5337

Open
AkihiroSuda wants to merge 1 commit into
opencontainers:release-1.3from
AkihiroSuda:cherrypick-5330-1.3
Open

[release-1.3] features: propagate version from the root urfave/cli command#5337
AkihiroSuda wants to merge 1 commit into
opencontainers:release-1.3from
AkihiroSuda:cherrypick-5330-1.3

Conversation

@AkihiroSuda

@AkihiroSuda AkihiroSuda commented Jun 19, 2026

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda added the backport/1.3-pr A backport PR to release-1.3 label Jun 19, 2026
@AkihiroSuda AkihiroSuda force-pushed the cherrypick-5330-1.3 branch from 45567e6 to e043f80 Compare June 19, 2026 10:24
Fix opencontainers#5329
Fix opencontainers#5331

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 7dda063)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit c8a2d9b)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the cherrypick-5330-1.3 branch from e043f80 to dd057b6 Compare June 19, 2026 10:35
@AkihiroSuda AkihiroSuda marked this pull request as draft June 19, 2026 10:35

@cyphar cyphar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codespell failure is from the security release, I must've forgotten to push the codespell-fixed version to 1.3.z? Let me prep a PR.

@AkihiroSuda AkihiroSuda marked this pull request as ready for review June 19, 2026 10:57
@rata

rata commented Jun 19, 2026

Copy link
Copy Markdown
Member

CI failing due to the typo @cyphar mentioned and also because we lack the fix from #5322

@rata rata left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

Copy link
Copy Markdown
Member

Looks like code spell picked up some issue;

Screenshot 2026-06-19 at 15 05 15

@cyphar

cyphar commented Jun 19, 2026

Copy link
Copy Markdown
Member

I mentioned it above, but looking at it again these aren't from the CVE fix so I'm not sure what triggered it to start failing now... Anyway, #5339 should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.3-pr A backport PR to release-1.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants