Skip to content

vendor: update moby/sys/userns to v0.2.0 - #5396

Merged
kolyshkin merged 1 commit into
opencontainers:mainfrom
aleivag:update-moby-sys-userns-0.2.0
Aug 14, 2026
Merged

vendor: update moby/sys/userns to v0.2.0#5396
kolyshkin merged 1 commit into
opencontainers:mainfrom
aleivag:update-moby-sys-userns-0.2.0

Conversation

@aleivag

@aleivag aleivag commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

updating moby/sys/userns in runc so it can identiofy when its not on the root namespace (includes moby/sys#240 )

@aleivag
aleivag marked this pull request as ready for review August 12, 2026 15:14

@kolyshkin kolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin

kolyshkin commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Some ci failures are flakes caused by github; opened lima-vm/lima-actions#8 and #5397

ci restarted

Comment thread go.sum Outdated
github.com/moby/sys/user v0.4.1/go.mod h1:E9QsW5WRe1kUAf7kW8hXKwu1uhsZEAdPLYHYSDudF4Y=
github.com/moby/sys/userns v0.1.0 h1:tVLXkFOxVu9A64/yh59slHVv9ahO9UIev4JZusOLG/g=
github.com/moby/sys/userns v0.1.0/go.mod h1:IHUYgu/kao6N8YZlp9Cf444ySSvCmDlmzUcYfDHOl28=
github.com/moby/sys/userns v0.2.0 h1:okipYTjUbjPLZ6Sbd4rbpPGE5GvsTr75mFERfKzjqB4=

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I did

go get github.com/moby/sys/userns@latest
make vendor

locally and I have this in go.sum:

github.com/moby/sys/userns v0.2.0 h1:nEtDtp7NCV/6dutSklNe8FrENPwFdc4mXnZqC/JWgXM=
github.com/moby/sys/userns v0.2.0/go.mod h1:IHUYgu/kao6N8YZlp9Cf444ySSvCmDlmzUcYfDHOl28=

CI job (validate/deps, see here) shows the same thing. Wonder why you have different checksum?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are right... i think my local cache was borked... make vendor now pass

@kolyshkin
kolyshkin self-requested a review August 13, 2026 18:06
Signed-off-by: Alvaro Leiva Geisse <aleivag@gmail.com>
@aleivag
aleivag force-pushed the update-moby-sys-userns-0.2.0 branch from bb86120 to 0c2a28f Compare August 13, 2026 21:38

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleivag

aleivag commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

the failing ci test is what #5401 fixes... right @kolyshkin ?

@kolyshkin

Copy link
Copy Markdown
Contributor

the failing ci test is what #5401 fixes... right @kolyshkin ?

Basically, yes (so this one can be merged).

@kolyshkin kolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
kolyshkin merged commit 71747fb into opencontainers:main Aug 14, 2026
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants