Repository navigation
Improve installation docs and handle localized column names - #150
Merged
Merged
Conversation
OpenRefine names columns without header by the JVM's default locale (e.g. "Spalte 1" on a German macOS), which made tests fail and run scripts depend on the system language. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018cVmGKtERaZJ91gCAA8Jj2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018cVmGKtERaZJ91gCAA8Jj2
Symlink to /usr/local/bin (in the default PATH on Linux and macOS) and add zsh tab completion via bashcompinit for macOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018cVmGKtERaZJ91gCAA8Jj2
Revert starting OpenRefine with -Duser.language=en in run and test, because the language also matters for features like reconciliation. Tests with default column names (e.g. "Spalte 1" on a German macOS) now normalize the header row of the output to "Column 1". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018cVmGKtERaZJ91gCAA8Jj2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018cVmGKtERaZJ91gCAA8Jj2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the installation documentation with platform-specific instructions and fixes test failures caused by OpenRefine's localization of default column names (e.g., "Spalte 1" on German systems instead of "Column 1").
Key Changes
README.md: Restructured installation instructions with separate sections for Linux and macOS, including:
.dmglacks the requiredrefinescript)Test files (
import-csv-headerLines.sh,import-csv-ignoreCharacter.sh,import-txt-headerLines.sh,import-txt-linesPerRow.sh,import-txt.sh):sedto convert language-specific column names (e.g., "Spalte 1", "Colonne 1") to English "Column N" formatImplementation Details
The test fixes use a portable
sedpattern (sed $'1s/[^\t ]* \\([0-9][0-9]*\\)/Column \\1/g') that:sedoptions to maintain macOS compatibilityhttps://claude.ai/code/session_018cVmGKtERaZJ91gCAA8Jj2