-
Notifications
You must be signed in to change notification settings - Fork 89
Add CNCF Incubation announcement blog post #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughA new author entry "jakub" is added to the authors configuration, and a new blog post announcing OpenFGA's acceptance into CNCF Incubation is introduced with metadata and content sections. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
static/img/blog/authors/jakub.jpgis excluded by!**/*.jpg
📒 Files selected for processing (2)
blog/authors.yml(1 hunks)blog/incubation-announcement.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
blog/incubation-announcement.md
[grammar] ~13-~13: Use a hyphen to join words.
Context: ...eflects years of community work and real world adoption. - CNCF announcement: [O...
(QB_NEW_EN_HYPHEN)
[style] ~45-~45: Consider using a synonym to be more concise.
Context: ...er maintainer diversity. ## Thank You A lot of people contributed to OpenFGA's success...
(A_LOT_OF)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Run Checks
- GitHub Check: markdown-link-check-md
- GitHub Check: deploy-preview
- GitHub Check: Test deployment
🔇 Additional comments (6)
blog/incubation-announcement.md (4)
1-10: Verify frontmatter metadata and image URL.The frontmatter is well-structured. However, line 8 uses an absolute URL (
https://openfga.dev/img/og-rich-embed.png) whereas other image references inauthors.ymluse relative paths. Confirm this is intentional (e.g., for SEO or external sharing) or align with the relative path convention used elsewhere in the codebase.Additionally, the
authorsfield references bothaaguiarandjakub, which is consistent with the new author entry added toblog/authors.yml.
32-38: Verify factual accuracy of statistics and adopter information.The "Journey So Far" section cites specific metrics (600+ contributors, 4,500 stars, 5 KubeCon editions, 2+ years of monthly meetings) and lists named production adopters (Canonical, Docker, Grafana Labs, Read AI, Agicap, Headspace, Zuplo, Sourcegraph). Ensure these statistics are current and correct, and that adopters have consented to be publicly named.
44-58: Acknowledgments are well-structured and inclusive.The "Thank You" section provides specific recognition to community members, maintainers, and CNCF stakeholders with their contributions clearly noted. This demonstrates strong community engagement and is a best practice for public projects.
70-75: Calls-to-action are clear and well-organized.The "Get Involved" section provides multiple entry points (GitHub, Slack, documentation, roadmap) with direct links, making it easy for readers to engage next.
blog/authors.yml (2)
10-13: Author entry is well-formed and consistent.The new
jakubauthor entry is properly formatted with all expected fields (name, url, image_url), follows the established YAML structure used by other authors, and maintains alphabetical ordering. The GitHub URL aligns with the PR branch author (curfew-marathon), and the relative image path is consistent with existing conventions.
10-13: Verify the author image file is present.The entry references
/img/blog/authors/jakub.jpg. Per the PR description, this image file is being added as part of this PR. Ensure the image is in the correct directory and meets any size/format requirements for the blog platform.
|
/easycla |
2896b13 to
b196c1d
Compare
|
/easycla |
Co-authored-by: Raghd Hamzeh <[email protected]>
Co-authored-by: Raghd Hamzeh <[email protected]>
Co-authored-by: Raghd Hamzeh <[email protected]>
Description
Adds blog post announcing OpenFGA's acceptance into CNCF Incubation stage.
Changes
incubation-announcement.mdauthors.ymljakub.jpgSummary by CodeRabbit