✨(api) modify basic auth credentials without reloading #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Cache the credentials file based on when it was last modified. - Also cache the users' decrypted data based on that information. Rationale: Right now, modifying the basic auth credentials file (adding a user, for instance) requires a server restart. This is because of caching at the credentials file level. Following the dicussion on [a previous PR] (openfun#337 (comment)) we propose to add the last modified time of the credentials file to the cache key for the credentials file and the users' data both. If caching of the credentials file seems unnecessary (as was discussed in the above PR), it may be removed without breaking this feature.
piptouque
force-pushed
the
feat_basic_auth_mod_reload
branch
from
9cc0d26 to
c9079e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #624
Proposal
Changes :