Skip to content

8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys#4477

Closed
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8370511-V17
Closed

8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys#4477
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8370511-V17

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented May 21, 2026

Backporting JDK-8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys.

This PR fixes test/jdk/javax/swing/JSlider/bug4382876.java to properly release pressed keys, preventing failures in subsequent tests on Wayland.

For parity with Oracle JDK. Already backported to 21.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/javax/swing/JSlider/bug4382876.java

Results:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370511 needs maintainer approval

Issue

  • JDK-8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4477/head:pull/4477
$ git checkout pull/4477

Update a local copy of the PR:
$ git checkout pull/4477
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4477/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4477

View PR using the GUI difftool:
$ git pr show -t 4477

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4477.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8 rm-gh-8 marked this pull request as ready for review May 21, 2026 14:49
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 21, 2026

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 21, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 8fe7d5e134991e21e8d74a22d17073e4e7035fb2 8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys May 21, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 21, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 21, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 21, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 21, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 21, 2026

Webrevs

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented May 21, 2026

/approval request for backport of JDK-8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys.

This is a test fix.

For parity with Oracle JDK. Already backported to 21.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 21, 2026

@rm-gh-8
8370511: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 21, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented May 26, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 26, 2026

Going to push as commit f0cd452.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label May 26, 2026
@openjdk openjdk Bot closed this May 26, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 26, 2026

@rm-gh-8 Pushed as commit f0cd452.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant