8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys#4477
8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys#4477rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys. This is a test fix. For parity with Oracle JDK. Already backported to 21. |
|
/integrate |
|
Going to push as commit f0cd452.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys.
This PR fixes test/jdk/javax/swing/JSlider/bug4382876.java to properly release pressed keys, preventing failures in subsequent tests on Wayland.
For parity with Oracle JDK. Already backported to 21.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/javax/swing/JSlider/bug4382876.java
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4477/head:pull/4477$ git checkout pull/4477Update a local copy of the PR:
$ git checkout pull/4477$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4477/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4477View PR using the GUI difftool:
$ git pr show -t 4477Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4477.diff
Using Webrev
Link to Webrev Comment