Skip to content

fix: resolve fragile tests - #334

Merged
alienvspredator merged 2 commits into
mainfrom
fix/fragile-tests
Jul 21, 2026
Merged

fix: resolve fragile tests#334
alienvspredator merged 2 commits into
mainfrom
fix/fragile-tests

Conversation

@alienvspredator

@alienvspredator alienvspredator commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Makes the tests run stable and faster by fixing the shared test-Postgres setup and letting test packages run in parallel.

Metric:
Tests runtime is 80s-92s on my machine.

Screenshot 2026-07-17 at 10 22 57

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a2a4151b-64e5-4ab9-9e34-740b2a1a7778

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

jmpTeixeira02
jmpTeixeira02 reviewed Jul 17, 2026
View reviewed changes
Comment thread Makefile Outdated
Comment thread internal/testutils/db.go Outdated
Comment thread internal/db/migrator.go Outdated
Comment thread internal/testutils/db.go

return base + "_" + suffix
}

@jmpTeixeira02 jmpTeixeira02 Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as long as we are still able to differentiate each test in the DB in case we need to debug stuff

@alienvspredator
alienvspredator force-pushed the fix/fragile-tests branch 2 times, most recently from 0917b42 to e877bdb Compare July 17, 2026 09:57
jmpTeixeira02
jmpTeixeira02 previously approved these changes Jul 17, 2026
View reviewed changes
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

alienvspredator and others added 2 commits July 17, 2026 15:55
@alienvspredator @jmpTeixeira02
fix: resolve fragile tests
cf0970c 
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
@jmpTeixeira02
fix: remove unnecessary withIsolatedService db opt
3f3b82d 
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
@alienvspredator
alienvspredator merged commit 94e81a1 into main Jul 21, 2026
6 checks passed
@alienvspredator
alienvspredator deleted the fix/fragile-tests branch July 21, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmpTeixeira02 jmpTeixeira02 jmpTeixeira02 approved these changes
@efrank-at-sap efrank-at-sap efrank-at-sap approved these changes
@bkieling bkieling Awaiting requested review from bkieling
@MarkMcAleese MarkMcAleese Awaiting requested review from MarkMcAleese
@minh-nghia minh-nghia Awaiting requested review from minh-nghia
@doanhluongsap doanhluongsap Awaiting requested review from doanhluongsap
@niazkhansap niazkhansap Awaiting requested review from niazkhansap

Assignees

No one assigned

Labels

bug Something isn't working dev-ops test tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alienvspredator @jmpTeixeira02 @efrank-at-sap