Repository navigation
Add NIC attach and detach support for NetH VMs - #972
Rachana-Kodal wants to merge 2 commits into
Conversation
960dfbb to
d74e1d6
Compare
|
The feature itself is clearly aimed at a real gap, but the NETH attach/config path has a couple of blockers in the new network configuration logic. zvmsdk/networkops.py: zdirect_network_configuration() calls self._create_invokeScript(network_file_path, clean_cmd, files_map, znetconfig=False), but the method defined in the same class only accepts (network_file_path, commands, files_map). That mismatch will raise a TypeError as soon as guest_configure_network_interface_ip() is used, so the attach flow cannot work end-to-end. |
|
Also check PEP8 failure |
d74e1d6 to
26aaa04
Compare
|
Issue 1 – Fix: This issue has been fixed in #970 Issue 2 – Fix: Replaced the loop with direct indexing (net = network[0]) because each function call handles a single network interface. This ensures the intended network configuration is processed without accidentally overwriting it with subsequent entries. |
Signed-off-by: Rachana Kodal <rachana.kodal@ibm.com>
8b8c7fc to
0a3eb51
Compare
Signed-off-by: Rachana Kodal <rachana.kodal@ibm.com>
What this PR does / why we need it:
Implements attach/detach NIC to the NetH VMs
Result:



