Skip to content

Conversation

@yardasol
Copy link
Contributor

@yardasol yardasol commented Jan 15, 2026

Description

This PR adds a pincell-type model utilizing the same cross section data as random_ray_lattice(). This gives users a smaller building block to create larger models from (i.e. a full core random ray model). This is somewhat redundant given that we can now create source regions from meshes, but I still think it has some use as an illustrative case.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@jtramm jtramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks for adding this in! Just a minor idea about naming, but then should be good to go.

@yardasol yardasol requested a review from jtramm January 22, 2026 18:09
Copy link
Contributor

@jtramm jtramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo fix, then should be good to go.

Co-authored-by: John Tramm <[email protected]>
@jtramm jtramm merged commit 73a98b2 into openmc-dev:develop Jan 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants