Update frontend to respect benchmark permissions#2106
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Home benchmark banner logic to also respect per-project benchmark permissions (OPS-3874), ensuring users without access don’t see the banner or trigger benchmark fetches.
Changes:
- Update
useShowBenchmarkBannerto require both theFINOPS_BENCHMARK_ENABLEDflag anduserMeta.projectPermissions.benchmark. - Adjust
useBenchmarkBannerStateto consume the updated hook return shape. - Add unit tests for the new permission-gated banner behavior and update existing banner state tests accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-ui/src/app/features/home/components/useShowBenchmarkBanner.ts | Gate banner visibility on both the feature flag and benchmark permission; expose pending state. |
| packages/react-ui/src/app/features/home/components/useShowBenchmarkBanner.test.ts | Add coverage for flag/permission combinations and pending behavior. |
| packages/react-ui/src/app/features/home/components/useBenchmarkBannerState.ts | Update to consume useShowBenchmarkBanner()’s new return shape. |
| packages/react-ui/src/app/features/home/components/useBenchmarkBannerState.test.ts | Update mocks/assertions to match the new useShowBenchmarkBanner() API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
packages/react-ui/src/app/features/home/components/useShowBenchmarkBanner.test.ts
Outdated
Show resolved
Hide resolved
|
alexandrudanpop
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes OPS-3874.