Repository navigation
Conversation
irl-dan
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assessors can miss incompatible numerical evidence while rejecting a subject for requirements it never had or information supplied only after it finished. Require each finding to identify its governing requirement and evidence, compare actual scoped values, and distinguish subject-time availability from later assessment access.
The SOFR assessor applies these distinctions without changing the original decision-note agreement or house requirements. Ten authored cases cover conflicts, equivalent units, scope, placement and temporal availability. No CLI, kernel or standard-library change is included.
Validation: all 35 repository check commands pass (including 20 unit tests and component package checks), and both exact-head CI jobs pass. Three live evaluator-only trials on saved SOFR notes now identify the previously missed conflict and avoid the earlier date/availability rejections. These trials combine the wording change with an explicit caller statement about evidence timing; they do not isolate either change's effect or estimate reliability.
Remaining defects: truncated evidence reads can be mistaken for absent evidence despite a complete-coverage claim; one assessment mixes historical reproduction and live-run metadata, and another fails to reconcile a subject's fulfillment claim with its detected violation. This PR is a targeted improvement, not a fully qualified assessor or workshop-ready release.
Stacked on #41. Publication and attendee qualification remain separate.