TRT-2549: Revert "Add a serial e2e for accept-risks"

[neisw]

Reverts #1310

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to console-operator panic

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

CC: @hongkailiu

[openshift-ci-robot]

@neisw: This pull request references OTA-1546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reverts #1310

Want to test recent serial test failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

This PR removes exported constants from the external and internal packages that provided defaults for Cluster Version Operator configuration, replacing them with hardcoded values in affected files. It also simplifies conformance suite qualifier logic by removing checks for "Serial" labels, deletes an integration test file, removes test utility functions, and updates a test manifest entry.

Changes

Cohort / File(s)	Summary
Manifest & Conformance Configuration .openshift-tests-extension/openshift_payload_cluster-version-operator.json, cmd/cluster-version-operator-tests/main.go	Removed a test payload entry; simplified parallel and serial conformance suite qualifiers by eliminating "Serial" label checks.
Constants Package Removals pkg/external/constants.go, pkg/internal/constants.go	Deleted exported constants (DefaultCVONamespace, DefaultClusterVersionName, DefaultDeploymentName, DefaultContainerName) that defined CVO defaults.
Hardcoded Constant Replacements lib/resourcebuilder/apps.go, pkg/cvo/sync_worker.go, pkg/start/start.go, test/cvo/cvo.go	Replaced external/internal constant references with hardcoded strings ("openshift-cluster-version", "version", "cluster-version-operator"); added new local constants in pkg/start and test/cvo.
Test File Deletions test/cvo/accept_risks.go, test/util/util.go	Removed full integration test file exercising AcceptRisks flow; deleted public utility functions (IsTechPreviewNoUpgrade, SkipIfNotTechPreviewNoUpgrade) and FauxinnatiAPIURL constant.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[neisw]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

[openshift-ci]

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60bd01a0-0ad4-11f1-8f07-aebdfbabbd0d-0

[openshift-ci-robot]

@neisw: This pull request references OTA-1546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reverts #1310

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to console-operator panic

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

CC: @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@neisw: This pull request references TRT-2549 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reverts #1310

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to console-operator panic

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

CC: @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[neisw]

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change
/override ci/prow/e2e-agnostic-ovn-techpreview-serial
/override ci/prow/e2e-agnostic-operator

deprovision, timeout and watch pod failures but all tests passed.

[openshift-ci]

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-agnostic-operator, ci/prow/e2e-agnostic-ovn-techpreview-serial, ci/prow/e2e-agnostic-ovn-upgrade-out-of-change

Details

In response to this:

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change
/override ci/prow/e2e-agnostic-ovn-techpreview-serial
/override ci/prow/e2e-agnostic-operator

deprovision, timeout and watch pod failures but all tests passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[neisw]

/test e2e-hypershift-conformance

[neisw]

/override ci/prow/e2e-hypershift-conformance

unrelated flakes

[neisw]

/verified by payload-job

[openshift-ci]

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-hypershift-conformance

Details

In response to this:

/override ci/prow/e2e-hypershift-conformance

unrelated flakes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@neisw: This PR has been marked as verified by payload-job.

Details

In response to this:

/verified by payload-job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[xueqzhan]

/lgtm

[hongkailiu]

/lgtm

[hongkailiu]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, neisw, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment