OTA-1861: data/bootstrap/files/usr/local/bin/bootkube: Pass CVO render --cluster-version-manifest-path#10295
Conversation
…r-version-manifest-path Like 9bbe172 (data/bootstrap/files/usr/local/bin/bootkube: Pass CVO render --feature-gate-manifest-path, 2024-08-07, openshift#8813), but for the ClusterVersion manifest laid down by pkg/asset/ignition/bootstrap/cvoignore.go. To populate the new flag provided by [1]. [1]: openshift/cluster-version-operator#1315
|
@wking: This pull request references OTA-1861 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold for openshift/cluster-version-operator#1315 to merge, because we can't set the flag until it exists (in both nightly and CI releases) |
|
openshift/cluster-version-operator#1315 merged. It isn't yet in 4.22 nightlies, so I'm not lifting the hold yet. But it should be in CI, so: /retest-required |
|
We're in nightlies now: $ oc adm release info --commits registry.ci.openshift.org/ocp/release:4.22.0-0.nightly-2026-02-21-040517 | grep cluster-version-operator
cluster-version-operator https://github.com/openshift/cluster-version-operator 8e4d0468c97a3811517f0ecd609876553ac1a481
$ oc adm release info --commits quay.io/openshift-release-dev/ocp-release-nightly@sha256:6c6b5f82f99a146908c73a9b394238dc7a54033a1d9be632af6264c1c08039d1 | grep '^Name:\|cluster-version-operator'
Name: 4.22.0-0.nightly-multi-2026-02-23-040809
cluster-version-operator https://github.com/openshift/cluster-version-operator 8e4d0468c97a3811517f0ecd609876553ac1a481
$ git log --oneline origin/release-4.22 | grep -n '8e4d046\|cluster-version-manifest-path'
1:8e4d0468c Merge pull request #1315 from wking/cluster-version-overrides-on-render
17:a837056f8 cmd/cluster-version-operator/render: Add --cluster-version-manifest-path option/hold cancel |
|
/verified by Cluster-bot with openshift/cluster-version-operator#1315 |
|
@QiWang19: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
QiWang19
left a comment
There was a problem hiding this comment.
/lgtm
/label acknowledge-critical-fixes-only
|
/lgtm |
|
/assign @patrickdillon |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Like 9bbe172 (#8813), but for the ClusterVersion manifest laid down by
pkg/asset/ignition/bootstrap/cvoignore.go. To populate the new flag provided by openshift/cluster-version-operator#1315.