Skip to content

MCO-2124 MCO-2125: migrate units and storage test cases#5660

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
sergiordlr:migrate_units_and_storage_tests
Feb 25, 2026
Merged

MCO-2124 MCO-2125: migrate units and storage test cases#5660
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
sergiordlr:migrate_units_and_storage_tests

Conversation

@sergiordlr
Copy link
Contributor

@sergiordlr sergiordlr commented Feb 13, 2026

- What I did
Migrate the test cases in the units test suite and the storage test suite from the private repo.

- How to verify it
All test must pass

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2026 •
edited by openshift-ci bot
Loading

@sergiordlr: This pull request references MCO-2124 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

This pull request references MCO-2125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
Migrate the test cases in the units test suite and the storage test suite from the private repo.

- How to verify it
All test must pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 13, 2026

Manual execution along with openshift/origin#30765

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration/2022343674687393792

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration/2022343879306514432

@sergiordlr sergiordlr force-pushed the migrate_units_and_storage_tests branch 2 times, most recently from 60cee42 to 5a7acc7 Compare February 16, 2026 11:03
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 16, 2026

Manual execution long with openshift/origin#30765

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration/2023358025653293056

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration/2023358238103179264

@sergiordlr sergiordlr force-pushed the migrate_units_and_storage_tests branch from 5a7acc7 to 9243f24 Compare February 17, 2026 09:29
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 17, 2026 •
edited
Loading

Manual execution
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration/2023699251497799680

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration/2023826161317974016

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 18, 2026

/test e2e-gcp-op-1of2

1 similar comment
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 18, 2026

/test e2e-gcp-op-1of2

@sergiordlr sergiordlr force-pushed the migrate_units_and_storage_tests branch from 9243f24 to 6801893 Compare February 18, 2026 13:58
@isabella-janssen
Copy link
Member

isabella-janssen commented Feb 18, 2026

/retest-required

@isabella-janssen
Copy link
Member

isabella-janssen commented Feb 18, 2026

It looks like the required tests for this PR are hitting this error https://redhat-internal.slack.com/archives/CFUGK0K9R/p1771413995217879. Since the fix has been merged, I'm hoping the tests start passing again, but the failures at least do not seem related to the changes in this PR.

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 18, 2026

Manual execution:

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-tp-longduration/2024160507304349696

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-fips-proxy-longduration/2024161539098939392

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 18, 2026

/retest-required

isabella-janssen
isabella-janssen reviewed Feb 18, 2026
View reviewed changes
Copy link
Member

@isabella-janssen isabella-janssen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Code looks clean. The new tests are passing, though some have skipped due to an unrelated, but known issue.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, sergiordlr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 18, 2026

/test e2e-gcp-op-ocl

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 19, 2026

/test e2e-hypershift
/test e2e-gcp-op-2of2
/test e2e-gcp-op-ocl

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 19, 2026

/test e2e-gcp-op-ocl

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 19, 2026

/verified by @sergiordlr

The problems in the tests configuring TLS have been already reported. If necessary, we will stop executing those tests until the issue is fixed.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2026

@sergiordlr: This PR has been marked as verified by @sergiordlr.

Details

In response to this:

/verified by @sergiordlr

The problems in the tests configuring TLS have been already reported. If necessary, we will stop executing those tests until the issue is fixed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 19, 2026

/test e2e-gcp-op-ocl

@umohnani8
Copy link
Contributor

umohnani8 commented Feb 23, 2026

/label acknowledge-critical-fixes-only

@umohnani8
Copy link
Contributor

umohnani8 commented Feb 23, 2026

/hold

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 23, 2026
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 23, 2026

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2026
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 24, 2026

/test e2e-gcp-op-single-node

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 24, 2026

/test e2e-hypershift

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 25, 2026

/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Feb 25, 2026

/test e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

@sergiordlr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bfa62f7 into openshift:main Feb 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

1 more reviewer

@isabella-janssen isabella-janssen isabella-janssen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@isabella-janssen isabella-janssen

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sergiordlr @openshift-ci-robot @isabella-janssen @umohnani8