Skip to content

OCPBUGS-60853: cert tests: mark TLS registry test as informing#30585

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
wangke19:cert-tests-informing
Feb 12, 2026
Merged

OCPBUGS-60853: cert tests: mark TLS registry test as informing#30585
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
wangke19:cert-tests-informing

Conversation

@wangke19
Copy link
Contributor

@wangke19 wangke19 commented Dec 9, 2025

Reapply the changes from PR #29074 that were previously reverted, mark both certificate tests as informing so failures don't block CI jobs, and skip the tests on ROSA clusters.

Current Skip Pattern:

The TLS certificate test currently skips on:

  1. MicroShift - doesn't auto-collect TLS (line 101-102)
  2. HyperShift - doesn't auto-collect TLS (line 105-106)
  3. ROSA - doesn't auto-collect TLS (line 108-109, your recent commit f7b77f2)

Other Managed Platforms - Analysis:

  1. ARO (Azure Red Hat OpenShift)
  • Regular ARO: Not hosted control plane, runs like standard OCP → should NOT skip
  • ARO HCP (Hosted Control Plane): This is a HyperShift variant
    • Already covered by the HyperShift skip check (line 105-106)
    • Detection: IsAroHCP() checks for MANAGED_SERVICE=ARO-HCP env var in control-plane-operator
  1. OSD (OpenShift Dedicated)
  • Runs on AWS or GCP with standard control plane architecture
  • Should NOT skip - uses regular TLS auto-collection like standard OCP
  • Note: Only ROSA (managed service on AWS) has the special behavior requiring a skip
  1. General Managed Service Detection
  • The codebase has IsManagedServiceCluster() (framework.go:2279) that checks for openshift-backplane namespace
  • This broadly detects OSD, ROSA, and other managed services but is not used for cert tests
  • This is intentional - not all managed services lack TLS auto-collection

Key Insight:

The distinction is based on control plane architecture, not managed service status:

  • Hosted/External Control Plane (HyperShift, ROSA, ARO HCP) → Skip
  • Self-hosted Control Plane (standard OCP, OSD, regular ARO) → Don't skip

Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
    • "all tls artifacts must be registered"
    • "all registered tls artifacts must have no metadata violation regressions"

Commit 3: Skip TLS certificate tests on ROSA clusters

  • Added IsRosaCluster() function to test/extended/util/framework.go
  • Skip certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Behavior

After these changes:

On standard OpenShift clusters:

  • Both certificate tests will continue to run in blocking CI jobs
  • Tests use g.Fail() for proper failure reporting
  • Tests have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

On ROSA, MicroShift, and Hypershift clusters:

  • Tests are skipped (these platforms don't auto-collect TLS the same way)

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Avoid running tests on platforms that don't support TLS auto-collection
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from deads2k and sdodson December 9, 2025 08:05
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@wangke19 wangke19 force-pushed the cert-tests-informing branch from 4a827c1 to a3db6b0 Compare December 9, 2025 08:45
@wangke19 wangke19 changed the title cert tests: mark TLS registry test as informing OCPBUGS-60853: cert tests: mark TLS registry test as informing Dec 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reapply the changes from PR #29074 that were previously reverted, and mark both certificate tests as informing so failures don't block CI jobs.

Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
  • "all tls artifacts must be registered"
  • "all registered tls artifacts must have no metadata violation regressions"

Behavior

After these changes, both certificate tests will:

  • Continue to run in blocking CI jobs
  • Use g.Fail() for proper failure reporting
  • Have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@wangke19
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 11, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: wangke19.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 15, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Reapply the changes from PR #29074 that were previously reverted, mark both certificate tests as informing so failures don't block CI jobs, and skip the tests on ROSA clusters.

Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
  • "all tls artifacts must be registered"
  • "all registered tls artifacts must have no metadata violation regressions"

Commit 3: Skip TLS certificate tests on ROSA clusters

  • Added IsRosaCluster() function to test/extended/util/framework.go
  • Skip certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Behavior

After these changes:

On standard OpenShift clusters:

  • Both certificate tests will continue to run in blocking CI jobs
  • Tests use g.Fail() for proper failure reporting
  • Tests have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

On ROSA, MicroShift, and Hypershift clusters:

  • Tests are skipped (these platforms don't auto-collect TLS the same way)

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Avoid running tests on platforms that don't support TLS auto-collection
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@wangke19
Copy link
Contributor Author

/assign @sanchezl

@wangke19
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Reapply the changes from PR #29074 that were previously reverted, mark both certificate tests as informing so failures don't block CI jobs, and skip the tests on ROSA clusters.

Current Skip Pattern:

The TLS certificate test currently skips on:

  1. MicroShift - doesn't auto-collect TLS (line 101-102)
  2. HyperShift - doesn't auto-collect TLS (line 105-106)
  3. ROSA - doesn't auto-collect TLS (line 108-109, your recent commit f7b77f2)

Other Managed Platforms - Analysis:

  1. ARO (Azure Red Hat OpenShift)
  • Regular ARO: Not hosted control plane, runs like standard OCP → should NOT skip
  • ARO HCP (Hosted Control Plane): This is a HyperShift variant
    • Already covered by the HyperShift skip check (line 105-106)
    • Detection: IsAroHCP() checks for MANAGED_SERVICE=ARO-HCP env var in control-plane-operator
  1. OSD (OpenShift Dedicated)
  • Runs on AWS or GCP with standard control plane architecture
  • Should NOT skip - uses regular TLS auto-collection like standard OCP
  • Note: Only ROSA (managed service on AWS) has the special behavior requiring a skip
  1. General Managed Service Detection
  • The codebase has IsManagedServiceCluster() (framework.go:2279) that checks for openshift-backplane namespace
  • This broadly detects OSD, ROSA, and other managed services but is not used for cert tests
  • This is intentional - not all managed services lack TLS auto-collection

Key Insight:

The distinction is based on control plane architecture, not managed service status:

  • Hosted/External Control Plane (HyperShift, ROSA, ARO HCP) → Skip
  • Self-hosted Control Plane (standard OCP, OSD, regular ARO) → Don't skip

Sources:

The openshift-backplane namespace is used by Red Hat's managed OpenShift offerings for SRE access:


Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
  • "all tls artifacts must be registered"
  • "all registered tls artifacts must have no metadata violation regressions"

Commit 3: Skip TLS certificate tests on ROSA clusters

  • Added IsRosaCluster() function to test/extended/util/framework.go
  • Skip certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Behavior

After these changes:

On standard OpenShift clusters:

  • Both certificate tests will continue to run in blocking CI jobs
  • Tests use g.Fail() for proper failure reporting
  • Tests have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

On ROSA, MicroShift, and Hypershift clusters:

  • Tests are skipped (these platforms don't auto-collect TLS the same way)

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Avoid running tests on platforms that don't support TLS auto-collection
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@sanchezl
Copy link
Contributor

/pipeline required

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@wangke19
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2026
@openshift-cherrypick-robot

@wangke19: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-trt
Copy link

openshift-trt bot commented Feb 6, 2026

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 9e6b56f

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vmware-vsphere-csi-driver-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vsphere-problem-detector-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vmware-vsphere-csi-driver-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vsphere-problem-detector-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 9e6b56f

  • "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vmware-vsphere-csi-driver-operator should not create excessive watch requests" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
  • "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vsphere-problem-detector-operator should not create excessive watch requests" [Total: 4, Pass: 4, Fail: 0, Flake: 0]

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bda0c70 and 1 for PR HEAD 9e6b56f in total

@openshift-trt
Copy link

openshift-trt bot commented Feb 6, 2026

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 9e6b56f

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vmware-vsphere-csi-driver-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vsphere-problem-detector-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vmware-vsphere-csi-driver-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vsphere-problem-detector-operator should not create excessive watch requests" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 9e6b56f

  • "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vmware-vsphere-csi-driver-operator should not create excessive watch requests" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
  • "[Monitor:audit-log-analyzer][Jira:"Test Framework"] operator service account vsphere-problem-detector-operator should not create excessive watch requests" [Total: 4, Pass: 4, Fail: 0, Flake: 0]

@wangke19
Copy link
Contributor Author

wangke19 commented Feb 8, 2026

/test e2e-aws-ovn-microshift

@wangke19
Copy link
Contributor Author

wangke19 commented Feb 8, 2026

/retest

@openshift-trt
Copy link

openshift-trt bot commented Feb 8, 2026

Job Failure Risk Analysis for sha: 9e6b56f

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (27) are below the historical average (1775): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wangke19
Copy link
Contributor Author

wangke19 commented Feb 8, 2026

/test e2e-aws-ovn-microshift

@openshift-trt
Copy link

openshift-trt bot commented Feb 8, 2026

Job Failure Risk Analysis for sha: 9e6b56f

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (27) are below the historical average (1759): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wangke19
Copy link
Contributor Author

/test e2e-aws-ovn-microshift

@wangke19
Copy link
Contributor Author

/test okd-scos-images

1 similar comment
@wangke19
Copy link
Contributor Author

/test okd-scos-images

@wangke19
Copy link
Contributor Author

/retest-required

@wangke19
Copy link
Contributor Author

/test okd-scos-images

3 similar comments
@wangke19
Copy link
Contributor Author

/test okd-scos-images

@wangke19
Copy link
Contributor Author

/test okd-scos-images

@wangke19
Copy link
Contributor Author

/test okd-scos-images

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@wangke19
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-trt
Copy link

openshift-trt bot commented Feb 12, 2026

Job Failure Risk Analysis for sha: 9e6b56f

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 Low
[Monitor:legacy-test-framework-invariants-pathological][sig-arch] events should not repeat pathologically
This test has passed 50.00% of 2 runs on release 4.22 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv6 Owner:eng Platform:metal Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
Metal ipv6 payload failures
MAPO creates events when reconciling machines

@wangke19
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 50bae19 into openshift:main Feb 12, 2026
20 checks passed
@openshift-ci-robot
Copy link

@wangke19: Jira Issue OCPBUGS-60853: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60853 has been moved to the MODIFIED state.

Details

In response to this:

Reapply the changes from PR #29074 that were previously reverted, mark both certificate tests as informing so failures don't block CI jobs, and skip the tests on ROSA clusters.

Current Skip Pattern:

The TLS certificate test currently skips on:

  1. MicroShift - doesn't auto-collect TLS (line 101-102)
  2. HyperShift - doesn't auto-collect TLS (line 105-106)
  3. ROSA - doesn't auto-collect TLS (line 108-109, your recent commit f7b77f2)

Other Managed Platforms - Analysis:

  1. ARO (Azure Red Hat OpenShift)
  • Regular ARO: Not hosted control plane, runs like standard OCP → should NOT skip
  • ARO HCP (Hosted Control Plane): This is a HyperShift variant
    • Already covered by the HyperShift skip check (line 105-106)
    • Detection: IsAroHCP() checks for MANAGED_SERVICE=ARO-HCP env var in control-plane-operator
  1. OSD (OpenShift Dedicated)
  • Runs on AWS or GCP with standard control plane architecture
  • Should NOT skip - uses regular TLS auto-collection like standard OCP
  • Note: Only ROSA (managed service on AWS) has the special behavior requiring a skip
  1. General Managed Service Detection
  • The codebase has IsManagedServiceCluster() (framework.go:2279) that checks for openshift-backplane namespace
  • This broadly detects OSD, ROSA, and other managed services but is not used for cert tests
  • This is intentional - not all managed services lack TLS auto-collection

Key Insight:

The distinction is based on control plane architecture, not managed service status:

  • Hosted/External Control Plane (HyperShift, ROSA, ARO HCP) → Skip
  • Self-hosted Control Plane (standard OCP, OSD, regular ARO) → Don't skip

Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
  • "all tls artifacts must be registered"
  • "all registered tls artifacts must have no metadata violation regressions"

Commit 3: Skip TLS certificate tests on ROSA clusters

  • Added IsRosaCluster() function to test/extended/util/framework.go
  • Skip certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Behavior

After these changes:

On standard OpenShift clusters:

  • Both certificate tests will continue to run in blocking CI jobs
  • Tests use g.Fail() for proper failure reporting
  • Tests have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

On ROSA, MicroShift, and Hypershift clusters:

  • Tests are skipped (these platforms don't auto-collect TLS the same way)

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Avoid running tests on platforms that don't support TLS auto-collection
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@wangke19: new pull request created: #30779

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@wangke19: #30585 failed to apply on top of branch "release-4.20":

Applying: Reapply "OCPBUGS-60853: make TLS registry tests required"
Using index info to reconstruct a base tree...
M	test/extended/operators/certs.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/operators/certs.go
CONFLICT (content): Merge conflict in test/extended/operators/certs.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Reapply "OCPBUGS-60853: make TLS registry tests required"

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@wangke19: #30585 failed to apply on top of branch "release-4.19":

Applying: Reapply "OCPBUGS-60853: make TLS registry tests required"
Using index info to reconstruct a base tree...
M	test/extended/operators/certs.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/operators/certs.go
CONFLICT (content): Merge conflict in test/extended/operators/certs.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Reapply "OCPBUGS-60853: make TLS registry tests required"

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@wangke19: #30585 failed to apply on top of branch "release-4.18":

Applying: Reapply "OCPBUGS-60853: make TLS registry tests required"
Using index info to reconstruct a base tree...
M	test/extended/operators/certs.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/operators/certs.go
CONFLICT (content): Merge conflict in test/extended/operators/certs.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Reapply "OCPBUGS-60853: make TLS registry tests required"

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19 wangke19 deleted the cert-tests-informing branch February 13, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants