Skip to content

Move oc-adm-upgrade-status and audit-log-analyzer to default #30765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergiordlr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move oc-adm-upgrade-status and audit-log-analyzer to default #30765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/defaultmonitortests/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ func newDefaultMonitorTests(info monitortestframework.MonitorTestInitializationI
monitorTestRegistry.AddMonitorTestOrDie(legacytestframeworkmonitortests.PathologicalMonitorName, "Test Framework", legacytestframeworkmonitortests.NewLegacyPathologicalMonitorTests(info))
monitorTestRegistry.AddMonitorTestOrDie("legacy-cvo-invariants", "Cluster Version Operator", legacycvomonitortests.NewLegacyTests())
monitorTestRegistry.AddMonitorTestOrDie("node-lifecycle", "Node / Kubelet", watchnodes.NewNodeWatcher())
monitorTestRegistry.AddMonitorTestOrDie("oc-adm-upgrade-status", "oc / update", admupgradestatus.NewOcAdmUpgradeStatusChecker())

return monitorTestRegistry
}
Expand Down Expand Up @@ -220,7 +221,5 @@ func newUniversalMonitorTests(info monitortestframework.MonitorTestInitializatio
monitorTestRegistry.AddMonitorTestOrDie("watch-namespaces", "Test Framework", watchnamespaces.NewNamespaceWatcher())
monitorTestRegistry.AddMonitorTestOrDie("high-cpu-test-analyzer", "Test Framework", highcputestanalyzer.NewHighCPUTestAnalyzer())

monitorTestRegistry.AddMonitorTestOrDie("oc-adm-upgrade-status", "oc / update", admupgradestatus.NewOcAdmUpgradeStatusChecker())

return monitorTestRegistry
}
10 changes: 10 additions & 0 deletions pkg/monitortests/kubeapiserver/auditloganalyzer/monitortest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,16 @@ func (w *auditLogAnalyzer) EvaluateTestsFromConstructedIntervals(ctx context.Con
// These usernames are already creating more than 200 applies, so flake instead of fail.
// We really want to find a way to track namespaces created by the payload versus everything else.
flakes = append(flakes, errorMessage)
case "system:serviceaccount:openshift-machine-config-operator:machine-config-daemon",
"system:serviceaccount:openshift-machine-config-operator:machine-config-controller":

// These usernames produce excessive applies in disruptive suites.
// Only flake in disruptive suites; fail in stable suites.
if w.clusterStability == monitortestframework.Disruptive {
flakes = append(flakes, errorMessage)
} else {
failures = append(failures, errorMessage)
}
default:
failures = append(failures, errorMessage)
}
Expand Down