Skip to content

Skip CO condition tests on SNO#30775

Open
hongkailiu wants to merge 1 commit intoopenshift:mainfrom
hongkailiu:skip-co-tests-on-sno
Open

Skip CO condition tests on SNO#30775
hongkailiu wants to merge 1 commit intoopenshift:mainfrom
hongkailiu:skip-co-tests-on-sno

Conversation

@hongkailiu
Copy link
Member

This pull skips all CO tests on SNO.

  • Available=False and Degrade=True are not checked at all no matter if the test case is executed in an upgrade test suite, or not. Before it was handled as an exception and thus the job would be just flaky instead of failing. Thus, the relevant exceptions can be removed.

  • All checks on the Progressing condition are skipped as well on a SNO cluster.

The logging logic was inherited if it fails to determine the control plane topology because I am not sure on which type of clusters an error will show up.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from deads2k and sjenning February 12, 2026 03:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@hongkailiu
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-agent-single-node-ipv6-conformance

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@hongkailiu: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@hongkailiu
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-single-node

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@hongkailiu: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@hongkailiu
Copy link
Member Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96b95810-0824-11f1-9668-f7261cec9d7e-0

@hongkailiu
Copy link
Member Author

hongkailiu commented Feb 12, 2026

From this job: skipping as expected.

$ curl -s 
<testcase name="[Monitor:legacy-cvo-invariants][bz-kube-apiserver] clusteroperator/kube-apiserver should not change condition/Available" time="9450.182493088">
<skipped message="Test skipped on a single-node cluster"/>
</testcase>

The cases are still running (passing) on non-SNO cluster:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/30775/pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade/2021794122666348544/artifacts/e2e-gcp-ovn-upgrade/openshift-e2e-test/artifacts/junit/e2e-monitor-tests__20260212-050021.xml | grep 'should not change condition/Available' -A1 | tail -n2
    <testcase name="[Monitor:legacy-cvo-invariants][bz-Storage] clusteroperator/storage should not change condition/Available" time="0"></testcase>
    <testcase name="[Monitor:legacy-cvo-invariants][bz-apiserver-auth] clusteroperator/authentication should not change condition/Degraded" time="0"></testcase>

The uncovered part is the scaling test but the code to determine SNO is quite similar.

/verified by @hongkailiu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 12, 2026
@openshift-ci-robot
Copy link

@hongkailiu: This PR has been marked as verified by @hongkailiu.

Details

In response to this:

From this job: skipping as expected.

$ curl -s 
<testcase name="[Monitor:legacy-cvo-invariants][bz-kube-apiserver] clusteroperator/kube-apiserver should not change condition/Available" time="9450.182493088">
<skipped message="Test skipped on a single-node cluster"/>
</testcase>

The cases are still running (passing) on non-SNO cluster:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/30775/pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade/2021794122666348544/artifacts/e2e-gcp-ovn-upgrade/openshift-e2e-test/artifacts/junit/e2e-monitor-tests__20260212-050021.xml | grep 'should not change condition/Available' -A1 | tail -n2
   <testcase name="[Monitor:legacy-cvo-invariants][bz-Storage] clusteroperator/storage should not change condition/Available" time="0"></testcase>
   <testcase name="[Monitor:legacy-cvo-invariants][bz-apiserver-auth] clusteroperator/authentication should not change condition/Degraded" time="0"></testcase>

/verified by @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This pull skips all CO tests on SNO.

- `Available=False` and `Degrade=True` are not checked at all no matter if the test case is executed in an upgrade test suite, or not. Before it was handled as an exception and thus the job would be just flaky instead of failing. Thus, the relevant exceptions can be removed.

- All checks on the `Progressing` condition are skipped as well on a SNO cluster.

The logging logic was inherited if it fails to determine the control plane topology because I am not sure on which type of clusters an error will show up.
@hongkailiu
Copy link
Member Author

/verified by @hongkailiu

@openshift-ci-robot
Copy link

@hongkailiu: This PR has been marked as verified by @hongkailiu.

Details

In response to this:

/verified by @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants