Skip to content

TRT-2545: Extend known image checker to cover openshift-must-gather-* namespaces#30777

Open
elfosardo wants to merge 1 commit intoopenshift:mainfrom
elfosardo:extend-known-image-checker-must-gather
Open

TRT-2545: Extend known image checker to cover openshift-must-gather-* namespaces#30777
elfosardo wants to merge 1 commit intoopenshift:mainfrom
elfosardo:extend-known-image-checker-must-gather

Conversation

@elfosardo
Copy link
Contributor

The known image checker validates that tests only pull images from approved sources (cluster payload, mirrored repos, internal registry) to ensure disconnected environment compatibility. Previously it only checked e2e-* namespaces, so images pulled by oc adm must-gather in openshift-must-gather-* namespaces were never validated.

This gap allowed operator-discovered must-gather images (e.g. cnv-must-gather-rhel9 from registry.redhat.io) to be pulled without detection, which would break disconnected clusters and caused pathological ImagePullBackOff events on IPv6-only clusters where registry.redhat.io is unreachable.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from deads2k and sjenning February 12, 2026 13:55
@smg247
Copy link
Member

smg247 commented Feb 12, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@elfosardo elfosardo changed the title Extend known image checker to cover openshift-must-gather-* namespaces TRT-2545: Extend known image checker to cover openshift-must-gather-* namespaces Feb 12, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 12, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2026

@elfosardo: This pull request references TRT-2545 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The known image checker validates that tests only pull images from approved sources (cluster payload, mirrored repos, internal registry) to ensure disconnected environment compatibility. Previously it only checked e2e-* namespaces, so images pulled by oc adm must-gather in openshift-must-gather-* namespaces were never validated.

This gap allowed operator-discovered must-gather images (e.g. cnv-must-gather-rhel9 from registry.redhat.io) to be pulled without detection, which would break disconnected clusters and caused pathological ImagePullBackOff events on IPv6-only clusters where registry.redhat.io is unreachable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link
Contributor Author

we need #30784 first

@elfosardo
Copy link
Contributor Author

/retest

1 similar comment
@elfosardo
Copy link
Contributor Author

/retest

The known image checker validates that tests only pull images from
approved sources (cluster payload, mirrored repos, internal registry)
to ensure disconnected environment compatibility. Previously it only
checked e2e-* namespaces, so images pulled by oc adm must-gather in
openshift-must-gather-* namespaces were never validated.

This gap allowed operator-discovered must-gather images (e.g.
cnv-must-gather-rhel9 from registry.redhat.io) to be pulled without
detection, which would break disconnected clusters and caused
pathological ImagePullBackOff events on IPv6-only clusters where
registry.redhat.io is unreachable.
@elfosardo elfosardo force-pushed the extend-known-image-checker-must-gather branch from a6890ba to 3c5f4ee Compare February 18, 2026 10:39
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@elfosardo
Copy link
Contributor Author

/retest

3 similar comments
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 3c5f4ee link true /test e2e-aws-ovn-fips
ci/prow/e2e-vsphere-ovn-upi 3c5f4ee link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn 3c5f4ee link true /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Feb 18, 2026

Job Failure Risk Analysis for sha: 3c5f4ee

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (77) are below the historical average (3462): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (22) are below the historical average (2068): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (69) are below the historical average (3416): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@elfosardo
Copy link
Contributor Author

/retest

1 similar comment
@elfosardo
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments