Skip to content

[WIP] OCPBUGS-76943: Fix dualstack BMC secret and BMH lookup using short name extraction#30788

Draft
clobrano wants to merge 3 commits intoopenshift:mainfrom
clobrano:fix/ocpbugs-76943-dualstack-bmc-secret-lookup
Draft

[WIP] OCPBUGS-76943: Fix dualstack BMC secret and BMH lookup using short name extraction#30788
clobrano wants to merge 3 commits intoopenshift:mainfrom
clobrano:fix/ocpbugs-76943-dualstack-bmc-secret-lookup

Conversation

@clobrano
Copy link
Contributor

@clobrano clobrano commented Feb 16, 2026

Extract short name from FQDN node names before pattern matching BMC secrets and BareMetalHosts. Updates RotateNodeBMCPassword and RestoreBMCPassword to use oc commands for consistency.

fixes: OCPBUGS-76943

Extract short name from FQDN node names before pattern matching
BMC secrets and BareMetalHosts. Updates RotateNodeBMCPassword and
RestoreBMCPassword to use oc commands for consistency.

fixes: OCPBUGS-76943
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 16, 2026
@openshift-ci-robot
Copy link

@clobrano: This pull request references Jira Issue OCPBUGS-76943, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (dhensel@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Extract short name from FQDN node names before pattern matching
BMC secrets and BareMetalHosts. Updates RotateNodeBMCPassword and
RestoreBMCPassword to use oc commands for consistency.

fixes: OCPBUGS-76943

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot
Copy link

@clobrano: This pull request references Jira Issue OCPBUGS-76943, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (dhensel@redhat.com), skipping review request.

Details

In response to this:

Extract short name from FQDN node names before pattern matching BMC secrets and BareMetalHosts. Updates RotateNodeBMCPassword and RestoreBMCPassword to use oc commands for consistency.

fixes: OCPBUGS-76943

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clobrano
Once this PR has been reviewed and has the lgtm label, please assign jeff-roche for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ab6d40c0-0b4c-11f1-9908-74254d90a978-0

@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1fd7e7f0-0bdc-11f1-8d5c-7afa9c9c7395-0

@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ec76d5a0-0bf5-11f1-9a34-d2a9bac30969-0

@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/349ed1f0-0c1b-11f1-96bc-ebc7b2439b73-0

@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/63497a90-0c21-11f1-80c9-e7d6709efd00-0

The function now extracts the short name from FQDN node names
(e.g., "master-1" from "master-1.ostest.test.metalkube.org") and
converts dashes to underscores to match VM naming conventions
(e.g., "ostest_master_1").
@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/93dcdc30-0c2e-11f1-93da-bfdc0119b53e-0

@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/098d1e60-0ca0-11f1-812d-e0af8d5b08dc-0

Select iptables binary based on peer IP version (ip6tables for IPv6,
iptables for IPv4).

Return early if the address is malformed
@clobrano
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

@clobrano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2a88bf70-0ccd-11f1-8791-faece5a7aad1-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants