Skip to content

[SREP-3734] Remove AlertmanagerInhibitions test (moved to CAMO)#3222

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smarthall:remove-inhibitions-test
May 28, 2026
Merged

[SREP-3734] Remove AlertmanagerInhibitions test (moved to CAMO)#3222
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smarthall:remove-inhibitions-test

Conversation

@smarthall
Copy link
Copy Markdown
Member

@smarthall smarthall commented Apr 29, 2026

Summary

  • Removes the AlertmanagerInhibitions test from pkg/e2e/osd/inhibitions.go — this test has been moved to the configure-alertmanager-operator repo's e2e suite
  • Cleans up the now-unused github.com/prometheus/alertmanager dependency and 6 transitive-only deps via go mod tidy

Test plan

  • go build ./... passes
  • go mod tidy produces no further changes

Related

The corresponding CAMO test addition: openshift/configure-alertmanager-operator#515

🤖 Generated with Claude Code

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9a64a898-ed92-4861-9b3b-543bc7505238

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@smarthall smarthall changed the title Remove AlertmanagerInhibitions test (moved to CAO) Remove AlertmanagerInhibitions test (moved to CAMO) Apr 29, 2026
@smarthall smarthall changed the title Remove AlertmanagerInhibitions test (moved to CAMO) [SREP-3734] Remove AlertmanagerInhibitions test (moved to CAMO) Apr 29, 2026
@smarthall
Copy link
Copy Markdown
Member Author

/hold Pending merge of openshift/configure-alertmanager-operator#515

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2026
@ritmun
Copy link
Copy Markdown
Contributor

ritmun commented Apr 29, 2026

/lgtm
/approve
/override ci/prow/hypershift-pr-check

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@ritmun: Overrode contexts on behalf of ritmun: ci/prow/hypershift-pr-check

Details

In response to this:

/lgtm
/approve
/override ci/prow/hypershift-pr-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026
The inhibitions test has been moved to the configure-alertmanager-operator
repo's e2e suite. Remove it from osde2e along with the now-unused
prometheus/alertmanager dependency.

Signed-off-by: Daniel Hall <danhall@redhat.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@smarthall smarthall force-pushed the remove-inhibitions-test branch from c327399 to 81521f6 Compare May 27, 2026 22:47
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2026
@smarthall
Copy link
Copy Markdown
Member Author

Rebased against main branch to resolve go dependency file conflicts.

@smarthall
Copy link
Copy Markdown
Member Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2026
@ritmun
Copy link
Copy Markdown
Contributor

ritmun commented May 28, 2026

/lgtm
/approve
/override ci/prow/hypershift-pr-check

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritmun, smarthall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

@ritmun: Overrode contexts on behalf of ritmun: ci/prow/hypershift-pr-check

Details

In response to this:

/lgtm
/approve
/override ci/prow/hypershift-pr-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 22f4221 into openshift:main May 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants