Add osde2e-common debugging guidelines to AGENTS.md#3229
Conversation
|
There are test jobs defined for this repository which are not configured to run automatically. Comment |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
| 1. **Never edit vendor directory directly** - changes will be overwritten by `go mod vendor` | ||
| 2. **Clone and fix in osde2e-common repo**: | ||
| ```bash | ||
| cd /Users/rmundhe/GolandProjects/osde2e-common |
There was a problem hiding this comment.
might be good to provide a relative path, like ../osde2e-common
| When debugging provisioning or cluster lifecycle issues in osde2e that originate from osde2e-common: | ||
|
|
||
| ### Identifying osde2e-common Issues | ||
| 1. **Check vendor path**: Issues in `/vendor/github.com/openshift/osde2e-common/` indicate upstream problems |
There was a problem hiding this comment.
/vendor/github.com/openshift/osde2e-common/
Is this your local path?
There was a problem hiding this comment.
per Claude,
Project-root notation: /vendor/ with a note that / means project root (common in some documentation styles)
For AGENTS.md, it should be changed to vendor/github.com/openshift/osde2e-common/ (without the leading slash) to avoid confusion, since it's describing a location within the repository.
|
/override ci/prow/hypershift-pr-check |
|
@ritmun: Overrode contexts on behalf of ritmun: ci/prow/hypershift-pr-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Documents workflow for debugging and fixing provisioning issues that originate in vendored osde2e-common dependencies, including: - How to identify osde2e-common issues - Proper workflow (never edit vendor, use local replace) - Common error handling patterns to fix - Testing and PR submission process
|
/lgtm |
|
/override ci/prow/hypershift-pr-check |
|
@YiqinZhang: Overrode contexts on behalf of YiqinZhang: ci/prow/hypershift-pr-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ritmun: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christophermancini, ritmun, YiqinZhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Documents workflow for debugging and fixing provisioning issues that
originate in vendored osde2e-common dependencies, including: