TRT-2795: Test Analysis: Regressions disappear when variant filters are applied#3785
Conversation
The variant filter comparison was extracting only the value part of
regression variants via parseVariantName (e.g. "gcp" from "Platform:gcp")
but comparing it against the full filter value ("Platform:gcp"), so the
match always failed. Fix by comparing the full variant string first, then
falling back to the parsed name for filters without a key prefix (e.g.
"never-stable", "aggregated").
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@openshift-trt-agent[bot]: This pull request references TRT-2795 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Hi @openshift-trt-agent[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@coderabbitai review |
|
/ok-to-test |
Action performedReview triggered.
|
|
/ok-to-test |
|
/test agentic-staging |
|
Scheduling required tests: |
Sippy Staging EnvironmentURL: https://removed-per-mailto-naturals.trycloudflare.com This environment is built from this PR and will remain available for approximately 60 minutes (until ~12:51 UTC). |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-trt-agent[bot], smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b2e2dc3
into
openshift:main



Summary
Fixes TRT-2795: Regressions disappear from the Test Analysis page when variant filters are applied.
TestRegressionsTablewas extracting only the value part of regression variants viaparseVariantName(e.g."gcp"from"Platform:gcp") but comparing it against the full filter value ("Platform:gcp"), so the match always failed and all regressions were filtered out.key:valuefilter values likePlatform:gcp), then falling back to the parsed name (handles value-only filter values likenever-stableandaggregated).Test plan
Platform:gcppositive filter, confirmed only the gcp regression (Add separate top ten lists for test failures with bugs and without bugs #3) is shownPlatform:gcpnegation filter, confirmed the two aws regressions (Initial #1, add web based reporting #2) are shownnever-stable,aggregated) continue to work correctlymake lintpassesmake testpasses (Go + Jest)Screenshots
Before filter (no variant filter applied, 3 regressions visible):
With
Platform:gcpfilter (only regression #3 shown):With NOT
Platform:gcpfilter (regressions #1 and #2 shown):Generated with Claude Code