Skip to content

TRT-2795: Test Analysis: Regressions disappear when variant filters are applied#3785

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
openshift-trt:trt-2795
Jul 17, 2026
Merged

TRT-2795: Test Analysis: Regressions disappear when variant filters are applied#3785
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
openshift-trt:trt-2795

Conversation

@openshift-trt-agent

Copy link
Copy Markdown

Summary

Fixes TRT-2795: Regressions disappear from the Test Analysis page when variant filters are applied.

  • The variant filter comparison in TestRegressionsTable was extracting only the value part of regression variants via parseVariantName (e.g. "gcp" from "Platform:gcp") but comparing it against the full filter value ("Platform:gcp"), so the match always failed and all regressions were filtered out.
  • Fixed by comparing the full variant string first (handles key:value filter values like Platform:gcp), then falling back to the parsed name (handles value-only filter values like never-stable and aggregated).

Test plan

Screenshots

Before filter (no variant filter applied, 3 regressions visible):

Regressions table before variant filter

With Platform:gcp filter (only regression #3 shown):

Regressions table with Platform:gcp filter applied

With NOT Platform:gcp filter (regressions #1 and #2 shown):

Regressions table with NOT Platform:gcp filter applied


Generated with Claude Code

The variant filter comparison was extracting only the value part of
regression variants via parseVariantName (e.g. "gcp" from "Platform:gcp")
but comparing it against the full filter value ("Platform:gcp"), so the
match always failed. Fix by comparing the full variant string first, then
falling back to the parsed name for filters without a key prefix (e.g.
"never-stable", "aggregated").

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 16, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 16, 2026

Copy link
Copy Markdown

@openshift-trt-agent[bot]: This pull request references TRT-2795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Fixes TRT-2795: Regressions disappear from the Test Analysis page when variant filters are applied.

  • The variant filter comparison in TestRegressionsTable was extracting only the value part of regression variants via parseVariantName (e.g. "gcp" from "Platform:gcp") but comparing it against the full filter value ("Platform:gcp"), so the match always failed and all regressions were filtered out.
  • Fixed by comparing the full variant string first (handles key:value filter values like Platform:gcp), then falling back to the parsed name (handles value-only filter values like never-stable and aggregated).

Test plan

Screenshots

Before filter (no variant filter applied, 3 regressions visible):

Regressions table before variant filter

With Platform:gcp filter (only regression #3 shown):

Regressions table with Platform:gcp filter applied

With NOT Platform:gcp filter (regressions #1 and #2 shown):

Regressions table with NOT Platform:gcp filter applied


Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 16, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci
openshift-ci Bot requested review from dgoodwin and xueqzhan July 16, 2026 19:16
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hi @openshift-trt-agent[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smg247

smg247 commented Jul 16, 2026

Copy link
Copy Markdown
Member

@coderabbitai review

@smg247

smg247 commented Jul 16, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
Action performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@smg247

smg247 commented Jul 17, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2026
@smg247

smg247 commented Jul 17, 2026

Copy link
Copy Markdown
Member

/test agentic-staging

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-trt-agent

Copy link
Copy Markdown
Author

Sippy Staging Environment

URL: https://removed-per-mailto-naturals.trycloudflare.com

This environment is built from this PR and will remain available for approximately 60 minutes (until ~12:51 UTC).

@smg247

smg247 commented Jul 17, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-trt-agent[bot], smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit b2e2dc3 into openshift:main Jul 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants