Skip to content

Update comments #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jancervenka wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update comments #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/playbooks/create_lightspeed_secret.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
# `run`. An in-cluster Secret is the only hand-off that survives: a job var is
# out of scope at serialization, set_fact doesn't cross the pre-run boundary,
# and a params file gets published by log collection. Uses `oc` because
# ci-framework's `kubernetes` lib is absent on `crc`.
# the Python `kubernetes` library required by Ansible's `kubernetes.core.k8s`
# module (used by CI-Framework) is absent on the CRC node.
- name: Pre-create the OpenStack Lightspeed API token Secret
hosts: crc
gather_facts: false
Expand Down
1 change: 0 additions & 1 deletion zuul.d/jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
secrets:
- name: openai_credentials
secret: lightspeed-openai-token
# Creates the token Secret in-cluster before the run (see playbook header).
pre-run: ci/playbooks/create_lightspeed_secret.yml
# cleanup: true so Zuul still attempts the delete when the job is canceled.
post-run:
Expand Down
Loading