Skip to content

[18-stable] Reconcile when custom route cert secret content changes - #2199

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:18-stablefrom
openshift-cherrypick-robot:cherry-pick-2198-to-18-stable
Oct 28, 2026
Merged

[18-stable] Reconcile when custom route cert secret content changes#2199
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:18-stablefrom
openshift-cherrypick-robot:cherry-pick-2198-to-18-stable

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 28, 2026 •
edited by stuggi
Loading

Copy link
Copy Markdown

This is an automated cherry-pick of #2198

/assign stuggi

Jira: OSPRH-39589
Jira: OSPRH-39944

@stuggi @claude @openshift-cherrypick-robot
Reconcile when custom route cert secret content changes
aa2cd29 
When a user updates the content of a secret referenced by
spec.<service>.apiOverride.tls.secretName, the control plane was not
reconciled, so the Routes kept the old certificate.

Index the apiOverride TLS secret names of all services so the existing
Secret watch enqueues the control plane. The existing field indexers and
allWatchFields are consolidated into a single fieldIndexers map, used for
both registration and lookup.

Add unit tests for the secret name collection (reflection based, fails
when a new Override field is not covered) and for findObjectsForSrc. Add
functional tests: a route update smoke test, and a test asserting the
watch registered by SetupWithManager enqueues the control plane, using a
second manager with a recording no-op reconcile.

Jira: OSPRH-39589

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 28, 2026
Merged
@openshift-ci
openshift-ci Bot requested review from abays and stuggi October 28, 2026 10:38
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 7f7088b9-73b1-4235-8ec8-1f6bcfbc3858

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@stuggi

stuggi commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

/test precommit-check

stuggi
stuggi approved these changes Oct 28, 2026
View reviewed changes

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 28, 2026
@openshift-ci

openshift-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi

stuggi commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick 18.0-fr7

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Oct 28, 2026

Copy link
Copy Markdown
Author

@stuggi: once the present PR merges, I will cherry-pick it on top of 18.0-fr7 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 29232dc into openstack-k8s-operators:18-stable Oct 28, 2026
6 checks passed
@openshift-cherrypick-robot

openshift-cherrypick-robot commented Oct 28, 2026

Copy link
Copy Markdown
Author

@stuggi: new pull request created: #2202

Details

In response to this:

/cherry-pick 18.0-fr7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuggi stuggi stuggi approved these changes
@abays abays Awaiting requested review from abays

Assignees

@stuggi stuggi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@openshift-cherrypick-robot @stuggi