Skip to content

chore: fix duplicate plugin warning and disable snapshots - #378

Merged
mkleene merged 1 commit into
mainfrom
fix-duplicate-plugin-warning-and-disable-snaphots
Jun 22, 2026
Merged

chore: fix duplicate plugin warning and disable snapshots#378
mkleene merged 1 commit into
mainfrom
fix-duplicate-plugin-warning-and-disable-snaphots

Conversation

@mkleene

@mkleene mkleene commented Jun 22, 2026

Copy link
Copy Markdown
Contributor
  • Don't use snapshots anymore since we don't publish them and we don't use them for 'integrate at HEAD' development
  • Consolidate the duplicate definition of the antrun plugin to eliminate maven warning

Summary by CodeRabbit

  • Chores
    • Updated release configuration settings across main and release branch configurations.
    • Reorganized Maven build profile configuration to improve build process consistency.

@mkleene
mkleene requested review from a team as code owners June 22, 2026 16:46

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures "skip-snapshot" to true in the release-please configuration files. Additionally, in sdk/pom.xml, it consolidates the maven-antrun-plugin executions into a single plugin definition and rearranges the order of the plugins by moving the maven-dependency-plugin below it. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68938d7b-a51c-4fc9-94bf-bb01e8e082ea

📥 Commits

Reviewing files that changed from the base of the PR and between 9b38f82 and aa6b7b3.

📒 Files selected for processing (3)
  • .github/release-please/release-please-config.main.json
  • .github/release-please/release-please-config.release_branches.json
  • sdk/pom.xml

📝 Walkthrough

Walkthrough

Two independent configuration updates: both release-please JSON configs gain "skip-snapshot": true, and the Maven fuzz profile in sdk/pom.xml has its maven-dependency-plugin copy-dependencies execution moved to a later position within the plugin list, with a comment update.

Changes

Release-please skip-snapshot

Layer / File(s) Summary
Add skip-snapshot to both release configs
.github/release-please/release-please-config.main.json, .github/release-please/release-please-config.release_branches.json
Adds "skip-snapshot": true at line 8 of both release-please configuration files.

Maven fuzz profile plugin reorder

Layer / File(s) Summary
Reorder copy-dependencies execution in fuzz profile
sdk/pom.xml
Updates a comment on line 548, removes the copy-dependencies execution from its earlier location after the download-and-unpack-jazzer antrun block, retains the run-jazzer-fuzzing antrun execution, and re-inserts the maven-dependency-plugin copy-dependencies execution at the end of the fuzz profile's plugins list with the same outputDirectory and includeScope=test configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A snapshot skipped, no ghost to chase,
The fuzzer's jars fall into place.
Config tweaked, the profile neat,
Two small changes, tidy, fleet.
Hop along — release complete! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: fixing a duplicate plugin warning in pom.xml and disabling snapshots in release configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-duplicate-plugin-warning-and-disable-snaphots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

@mkleene
mkleene merged commit 62779ef into main Jun 22, 2026
22 checks passed
@mkleene
mkleene deleted the fix-duplicate-plugin-warning-and-disable-snaphots branch June 22, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants