Skip to content

test related changes for xfail support in logs and new error messages #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
porlows1 wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −13
Open

test related changes for xfail support in logs and new error messages #4643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fdc580
better usage of xfail in tests
porlows1 Oct 8, 2026
9926c3f
update ovms_messages.py
porlows1 Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/functional/constants/ovms_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ class OvmsMessages:
ERROR_INVALID_LAYOUT_NHWC = "Received binary image input but resource not configured to accept NHWC layout"
ERROR_BINARY_INPUTS_CONVERSION_FAILED = "Binary inputs conversion failed."
ERROR_BINARY_INPUTS_NATIVE_FILE_FORMAT_CONVERSION = "Input native file format conversion failed"
ERROR_BINARY_INPUTS_DECODED_SIZE_ESTIMATION = "Decoded size could not be estimated for input"
ERROR_BINARY_INPUTS_CORRUPT_JPEG_DATA = "Corrupt JPEG data"

ERROR_INTERPOLATE_NODE_IS_NOT_SUPPORTED = "Interpolate node is not supported:"
Expand Down
26 changes: 13 additions & 13 deletions tests/functional/object_model/ovms_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,19 +399,19 @@ def get_signal_type(terminate_signal_type):
raise NotImplementedError(f"Unknown signal: {terminate_signal_type}")

def filter_unexpected_messages(self, unexpected_messages):
for msg in unexpected_messages:
# 1) This message is expected in OV tests with batch_size=0
# 2) This message can happen in Cython instances that use threading # CVS-165321
if all([
OvmsMessages.ERROR_TERMINATE_CALLED in msg,
self.context is not None and "test_ov_app_cpp_batch_size_0" in self.context.name,
]) or all([
OvmsMessages.ERROR_TERMINATE_CALLED in msg,
OvmsMessages.STD_SYSTEM_ERROR in msg,
hasattr(self, "cmd") and self.cmd is not None and "OvmsCapiInstance" in self.cmd.__str__,
]):
unexpected_messages.remove(msg)
return unexpected_messages
return [msg for msg in unexpected_messages if not self._is_expected_message(msg)]

def _is_expected_message(self, msg):
# 1) This message is expected in OV tests with batch_size=0
# 2) This message can happen in Cython instances that use threading # CVS-165321
return all([
OvmsMessages.ERROR_TERMINATE_CALLED in msg,
self.context is not None and "test_ov_app_cpp_batch_size_0" in self.context.name,
]) or all([
OvmsMessages.ERROR_TERMINATE_CALLED in msg,
OvmsMessages.STD_SYSTEM_ERROR in msg,
getattr(self, "cmd", None) is not None and "OvmsCapiInstance" in str(self.cmd),
])

def cleanup(self, timeout=30):
try:
Expand Down
Loading