build: file the package under Administration rather than Network - #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SECTIONmoves fromnettoadminandCATEGORYfromNetworktoAdministration. uapi is a management surface rather than a networking daemon, so it reads better beside the administration tools than beside the web servers.One correction to the premise, because it changes how much this matters. The shipped package carries no section or category. Reading the installed database on a device, the fields apk records for uapi are
A C D F I L M P R S T U V Z a f g k m o p, whereS:is the size in bytes; there is no section field, and nos:line exists for any of the 294 installed packages. So these two values never reach the artifact, the installed database, or the feed index.What they do affect is menuconfig placement for anyone building from source, which is the whole of the change.
Precedent is mixed, for the record. OpenWrt's
Administrationcategory is conventionally CLI sysadmin tooling:atop,btop,earlyoom,debootstrap. The closest functional analogue to uapi isrpcd, the ubus RPC backend, which sits inutils/Base system, whileuhttpd, which uapi runs inside, isnet/Networkunder aWeb Servers/Proxiessubmenu. An argument exists for any of the three.Administrationis a defensible pick and the one that matches how an operator thinks about the package.Does this change the wire surface? No, and it does not change the package either. Build-recipe metadata only.
Was it verified against a real device, or only by CI? The claim being verified here is the negative one, that this is invisible in the artifact, and that came from the installed database on the rc3 box.
make lintand 1230 unit tests pass. A local SDK rebuild to confirm the built package is unchanged ran past my time limit and is not part of the evidence;verify-arch-buildon a tag exercises it properly.Was LuCI checked? Not applicable. The companion
luci-app-uapipackage carries its own category and is untouched.If the preference is really about how the package presents to operators, worth knowing that the visible surface is
TITLE,T:in the database, which currently reads "Native HTTP REST API for OpenWrt". That one does ship, and can be changed independently of this.