fix: the provider link pointed at a registry namespace that does not exist - #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README pointed operators at
registry.terraform.io/providers/raspbeguy/uapi, which the registry does not serve. The provider moved to theopenwrt-iacnamespace with the rest of the org and nothing updated the links behind it.The registry website answers 200 for that address, which is why this survived: it is a single-page app that returns a shell for any path and reports the failure in the browser. Its API is the honest check.
The same dead link was in three more places, so fixing only the README would have left it shipping on the wire:
build/gen_openapi.uc, ininfo.descriptionandinfo.contact.url. That is the copy served from every router at/api/v3/openapi.jsonand rendered in the published API reference, so it reached more people than the README did. The spec is regenerated in this commit.tools/gen_sbom.sh, in the document namespace, the download location and the homepage. Every release attaches an SBOM built from those values, so the supply-chain metadata named an owner that no longer holds the repository.docs/release-process.md, in prose.The GitHub links under the old owner were stale rather than broken, because GitHub redirects a transferred repository. They are corrected anyway so the SBOM and the spec name the real location.
CHANGELOG.mdkeeps its four references. Those entries record the rename itself, and rewriting them would erase the history that explains why any of this exists.Wire surface: the served OpenAPI document changes. Only
info.descriptionandinfo.contact.urlmove, no path, schema, field or status code is touched, so this is a patch and no client can break on it.Verified against a real device, or only CI? Neither is needed. The claim is which URL the registry serves, and it was measured against the registry API directly, both namespaces, before and after.
make lint,make test-unitandmake openapi-checkpass.LuCI checked? Not applicable, no behavior or design choice changes.