Skip to content

use zimfarm UI URL instead of API URL#430

Merged
elfkuzco merged 1 commit into
mainfrom
zimfarm-recipe-ui-link
Jul 16, 2026
Merged

use zimfarm UI URL instead of API URL#430
elfkuzco merged 1 commit into
mainfrom
zimfarm-recipe-ui-link

Conversation

@elfkuzco

Copy link
Copy Markdown
Contributor

Changes

  • use zimfarm UI URL instead of API URL in env var to construct recipe link

This fixes #426

@elfkuzco elfkuzco self-assigned this Jul 16, 2026
@elfkuzco
elfkuzco requested a review from benoit74 July 16, 2026 14:29
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.77%. Comparing base (ce87dd1) to head (eb2e35d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
backend/src/cms_backend/__init__.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   80.69%   80.77%   +0.08%     
==========================================
  Files          64       64              
  Lines        3703     3709       +6     
  Branches      437      436       -1     
==========================================
+ Hits         2988     2996       +8     
+ Misses        576      575       -1     
+ Partials      139      138       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rather compute and return both links:

  • recipe_link is the link to the UI
  • recipe_api_link is the link to the API

Quite sure we will need both quite soon ^^

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@elfkuzco
elfkuzco force-pushed the zimfarm-recipe-ui-link branch from df6460f to eb2e35d Compare July 16, 2026 21:07
@elfkuzco
elfkuzco merged commit 1137df6 into main Jul 16, 2026
5 checks passed
@elfkuzco
elfkuzco deleted the zimfarm-recipe-ui-link branch July 16, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI link to Zimfarm recipe should be to Zimfarm UI instead of API

2 participants